You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2013/09/11 21:52:11 UTC
Review Request 14091: Kafka patch review tool
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description
-------
Review for the patch review tool
Diffs
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
> On Sept. 13, 2013, 4:58 p.m., Guozhang Wang wrote:
> > kafka-patch-review.py, line 43
> > <https://reviews.apache.org/r/14091/diff/9/?file=351276#file351276line43>
> >
> > If version is not specified, then v1 is used as default: I think this might mess up the ticket attachments from multiple RBs if people just forgot to use -v command. Does jira have getting attachment cmd so we can read the file names and automatically figure out the versions? If not we can at least force -v to be required and then if -r is not set ignore this parameter.
That is a very good suggestion. Will upload another patch with this fixed.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26082
-----------------------------------------------------------
On Sept. 12, 2013, 9:23 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 9:23 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Changed the script to use the jira-python package
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26082
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50911>
If version is not specified, then v1 is used as default: I think this might mess up the ticket attachments from multiple RBs if people just forgot to use -v command. Does jira have getting attachment cmd so we can read the file names and automatically figure out the versions? If not we can at least force -v to be required and then if -r is not set ignore this parameter.
- Guozhang Wang
On Sept. 12, 2013, 9:23 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 9:23 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Changed the script to use the jira-python package
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26140
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment51047>
Just one thing, I am not super comfortable having a password in a file in plain text.
- Swapnil Ghike
On Sept. 16, 2013, 3:28 a.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 3:28 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
>
>
> Use underscore to separate jira, date and time in patch name
>
>
> Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26141
-----------------------------------------------------------
Ship it!
Ship It!
- Swapnil Ghike
On Sept. 16, 2013, 3:28 a.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2013, 3:28 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> 1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
>
>
> Use underscore to separate jira, date and time in patch name
>
>
> Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 9:40 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting
Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting
1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
Use underscore to separate jira, date and time in patch name
Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 16, 2013, 3:28 a.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
Use underscore to separate jira, date and time in patch name
Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 15, 2013, 4:40 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote:
> > kafka-patch-review.py, lines 50-51
> > <https://reviews.apache.org/r/14091/diff/11/?file=352200#file352200line50>
> >
> > Do you intend to save the patch file in current directory? I wonder if we should delete it, because it is more of a side effect with this tool.
I don't think we need to cleanup after this tool since patch files are very small in size. Users can easily do that.
> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote:
> > kafka-patch-review.py, line 77
> > <https://reviews.apache.org/r/14091/diff/11/?file=352200#file352200line77>
> >
> > Not sure if there should be a space after -r, or if should be --rb=
Every command line option has a short-hand version that can be specified using one "-". This is true of most command line tools. You can read the short and full versions of all options using --help
> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote:
> > kafka-patch-review.py, lines 41-43
> > <https://reviews.apache.org/r/14091/diff/11/?file=352200#file352200line41>
> >
> > This is definitely useful. But I can specify versions out of order and confuse the reviewer. Is it possible to read the versions attached on the JIRA, and auto-increment the latest version by one?
> >
> > Wondering if there is a jira.get_attachments() function..
Now that I think more about version, I doubt it is useful for the user to specify it. If it is not completely automated like you said, users could make mistakes and get the versions incorrect. Auto incrementing by reading from the jira is overly complicated. I think a <jira>-<timestamp>.patch is a better approach. That way it is completely automated and easy to reason about
> On Sept. 14, 2013, 7:07 p.m., Swapnil Ghike wrote:
> > kafka-patch-review.py, line 22
> > <https://reviews.apache.org/r/14091/diff/11/?file=352200#file352200line22>
> >
> > Should we make it default to the current branch?
> >
I think with multiple branches in progress, it is better for the branch field to be explicit. That way fewer people will make mistakes while uploading patches using the tool. If it is automated, users might make mistakes and upload incorrect patches to JIRA and reviewboard and not realize it.
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26115
-----------------------------------------------------------
On Sept. 15, 2013, 4:40 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2013, 4:40 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Swapnil Ghike <sg...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26115
-----------------------------------------------------------
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50967>
Should we make it default to the current branch?
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50966>
This is definitely useful. But I can specify versions out of order and confuse the reviewer. Is it possible to read the versions attached on the JIRA, and auto-increment the latest version by one?
Wondering if there is a jira.get_attachments() function..
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50968>
Do you intend to save the patch file in current directory? I wonder if we should delete it, because it is more of a side effect with this tool.
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50970>
p should be closed.
kafka-patch-review.py
<https://reviews.apache.org/r/14091/#comment50969>
Not sure if there should be a space after -r, or if should be --rb=
- Swapnil Ghike
On Sept. 13, 2013, 11:33 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 11:33 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 11:33 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
> On Sept. 13, 2013, 10:48 p.m., Sriram Subramanian wrote:
> > Might be useful to publish it widely
Makes sense. I just got pinged by Helix, they want to use the tool. Probably publishing it on github will be useful to a lot of projects. Thanks!
- Neha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26109
-----------------------------------------------------------
On Sept. 13, 2013, 10:34 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 10:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Sriram Subramanian <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26109
-----------------------------------------------------------
Might be useful to publish it widely
- Sriram Subramanian
On Sept. 13, 2013, 10:34 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 10:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Sriram Subramanian <sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/#review26108
-----------------------------------------------------------
Ship it!
Ship It!
- Sriram Subramanian
On Sept. 13, 2013, 10:34 p.m., Neha Narkhede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14091/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2013, 10:34 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1053
> https://issues.apache.org/jira/browse/KAFKA-1053
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Included Guozhang's suggestion about making --version mandatory if --rb is specified
>
>
> Attaching file using jira-python package
>
>
> Changed the script to use the jira-python package, part 2
>
>
> Changed the script to use the jira-python package
>
>
> Changed the creating a reviewboard comment as suggested by Tejas
>
>
> Included Tejas's comments
>
>
> Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
>
>
> publish automatically
>
>
> Patch review tool
>
>
> Diffs
> -----
>
> .reviewboardrc PRE-CREATION
> kafka-patch-review.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neha Narkhede
>
>
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 13, 2013, 10:34 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Included Guozhang's suggestion about making --version mandatory if --rb is specified
Attaching file using jira-python package
Changed the script to use the jira-python package, part 2
Changed the script to use the jira-python package
Changed the creating a reviewboard comment as suggested by Tejas
Included Tejas's comments
Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
publish automatically
Patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 9:23 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description
-------
Changed the script to use the jira-python package
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Patch for KAFKA-1053
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 9:22 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1053
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Changed the script to use the jira-python package
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 12, 2013, 5:04 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Review for the patch review tool. Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the review board. Included all of Tejas's comments.
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 8:44 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Review for the patch review tool. Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA. Included Tejas's review comments
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 8:18 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Review for the patch review tool. Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 7:56 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description
-------
Review for the patch review tool. Changed the post-review tool to publish the rb automatically
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 7:55 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description (updated)
-------
Review for the patch review tool. Changed the post-review tool to publish the rb automatically
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede
Re: Review Request 14091: Kafka patch review tool
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14091/
-----------------------------------------------------------
(Updated Sept. 11, 2013, 7:53 p.m.)
Review request for kafka.
Bugs: KAFKA-1053
https://issues.apache.org/jira/browse/KAFKA-1053
Repository: kafka
Description
-------
Review for the patch review tool
Diffs (updated)
-----
.reviewboardrc PRE-CREATION
kafka-patch-review.py PRE-CREATION
Diff: https://reviews.apache.org/r/14091/diff/
Testing
-------
Thanks,
Neha Narkhede