You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/11/30 14:52:00 UTC
[jira] [Commented] (QPID-8243) [Broker-J] Optimize logback turbo
filter implemented to provide a workaround for Logback1027
[ https://issues.apache.org/jira/browse/QPID-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16704837#comment-16704837 ]
ASF subversion and git services commented on QPID-8243:
-------------------------------------------------------
Commit 21b5a21bf09fe85ed02f69e92c7ce8eeae88c4b6 in qpid-broker-j's branch refs/heads/7.0.x from [~alex.rufous]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=21b5a21 ]
QPID-8243: Optimize Logback1027 turbo filter
(cherry picked from commit 77d461aaa92e9772cf4203a70219b4e847dc6f50)
> [Broker-J] Optimize logback turbo filter implemented to provide a workaround for Logback1027
> --------------------------------------------------------------------------------------------
>
> Key: QPID-8243
> URL: https://issues.apache.org/jira/browse/QPID-8243
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-7.0.6
> Reporter: Alex Rudyy
> Assignee: Alex Rudyy
> Priority: Minor
> Fix For: qpid-java-broker-7.1.0, qpid-java-broker-7.0.7
>
>
> Whilst investigating a performance issue reported as part of QPID-8238 I ran a java profiler which had detected some performance loss on invocations of {{Logback1027WorkaroundTurboFilter}} due to creation of {{IdentityHashMap}} which is only required when {{Throwable}} is logged. In many cases when string messages are logged the creation of {{IdentityHashMap}} is redundant. It waists CPU resource and creates extra work for GC.
> I committed some changes [https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c30e8ae] to create {{IdentityHashMap}} only when {{Throwable}} is supplied.
> Following [review comments from Keith Wall|https://issues.apache.org/jira/browse/QPID-8238?focusedCommentId=16610224&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16610224], I raised this JIRA to track {{Logback1027WorkaroundTurboFilter}} changes and reapply the commit [c30e8ae|https://git-wip-us.apache.org/repos/asf?p=qpid-broker-j.git;h=c30e8ae].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org