You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/12 00:05:35 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
mik-laj opened a new pull request #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142
Hello,
I know that this is a very large PR, but unfortunately, it is not possible to divide it, because these classes are very close together on the lists in `test_core_to_contrib.py` file, documentation and others.
If we don't do it in bulk, we will constantly fight merge conflicts and AIP-21 will not be finalized in the next six months (100+ integration * 1.5 day =150 days, 150 days * (7/ 5) [exclude weekend] = 210 days, 210 days = 6.89 month = 0.57 year).
Best regards,
Kamil
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [X] Description above provides context of the change
- [X] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `85.11%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.27% +0.02%
==========================================
Files 683 707 +24
Lines 39155 39251 +96
==========================================
+ Hits 33378 33470 +92
- Misses 5777 5781 +4
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [77 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...5be5384](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573404295
Besides the static check - looks good !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573402964
I fixed issues related to HDFS Sensor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573389953
Can you check if full compatibility has been maintained?
For example:
```
# pylint: disable=unused-import
from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook # noqa
```
If `airflow.providers.apache.pinot.hooks.pinot` package contains two classess, then two classes should be imported. The selection of classes was manual, because I did not want to maintain compatibility with BaseHook or other not important stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `85.52%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 683 707 +24
Lines 39155 39254 +99
==========================================
+ Hits 33378 33477 +99
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...7edcca3](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `85.11%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.27% +0.02%
==========================================
Files 683 707 +24
Lines 39155 39251 +96
==========================================
+ Hits 33378 33470 +92
- Misses 5777 5781 +4
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [77 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...5be5384](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573389953
Can you check if full compatibility has been maintained?
For example:
```
# pylint: disable=unused-import
from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook # noqa
```
If `airflow.providers.apache.pinot.hooks.pinot` package contains two classess, then two classes should be imported and two classes should be added in `test_core_to_contrib.py` file. The selection of classes was manual, because I did not want to maintain compatibility with BaseHook or other not important stuff.
It's not WI now. I waited for last Travis's build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `85.52%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 683 707 +24
Lines 39155 39254 +99
==========================================
+ Hits 33378 33477 +99
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...7edcca3](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573389953
Can you check if full compatibility has been maintained?
For example:
```
# pylint: disable=unused-import
from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook # noqa
```
If `airflow.providers.apache.pinot.hooks.pinot` package contains two classess, then two classes should be imported and two classes should be added in `test_core_to_contrib.py` file. The selection of classes was manual, because I did not want to maintain compatibility with BaseHook or other not important stuff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `85.52%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.28% +0.03%
==========================================
Files 683 707 +24
Lines 39155 39254 +99
==========================================
+ Hits 33378 33477 +99
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [76 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...7edcca3](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573404336
I run those diffs and it's great!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573389953
Can you check if full compatibility has been maintained?
For example:
```
# pylint: disable=unused-import
from airflow.providers.apache.pinot.hooks.pinot import PinotAdminHook, PinotDbApiHook # noqa
```
If `airflow.providers.apache.pinot.hooks.pinot` package contains two classess, then two classes should be imported and two classes should be added in `test_core_to_contrib.py` file. The selection of classes was manual, because I did not want to maintain compatibility with BaseHook or other not important stuff.
It's not WIP..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `85.11%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.27% +0.02%
==========================================
Files 683 707 +24
Lines 39155 39251 +96
==========================================
+ Hits 33378 33470 +92
- Misses 5777 5781 +4
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [77 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...5be5384](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573381395
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/d654d69d7794a57c5c51685a8a96f1d7c38c2302?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `85.11%`.
[](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 85.24% 85.27% +0.02%
==========================================
Files 683 707 +24
Lines 39155 39251 +96
==========================================
+ Hits 33378 33470 +92
- Misses 5777 5781 +4
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/apache/spark/hooks/spark\_jdbc\_script.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL3NwYXJrL2hvb2tzL3NwYXJrX2pkYmNfc2NyaXB0LnB5) | `0% <ø> (ø)` | |
| [airflow/macros/hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tYWNyb3MvaGl2ZS5weQ==) | `38.7% <0%> (ø)` | :arrow_up: |
| [airflow/models/connection.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvY29ubmVjdGlvbi5weQ==) | `68.78% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/vertica\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy92ZXJ0aWNhX3RvX2hpdmUucHk=) | `0% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/spark\_submit\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zcGFya19zdWJtaXRfb3BlcmF0b3IucHk=) | `100% <100%> (+7.14%)` | :arrow_up: |
| [airflow/hooks/hive\_hooks.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9oaXZlX2hvb2tzLnB5) | `100% <100%> (+22.44%)` | :arrow_up: |
| [...flow/providers/apache/hive/operators/hive\_stats.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL2hpdmVfc3RhdHMucHk=) | `100% <100%> (ø)` | |
| [airflow/operators/s3\_to\_hive\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvczNfdG9faGl2ZV9vcGVyYXRvci5weQ==) | `93.96% <100%> (ø)` | :arrow_up: |
| [airflow/operators/hive\_stats\_operator.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvaGl2ZV9zdGF0c19vcGVyYXRvci5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/sensors/web\_hdfs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZW5zb3JzL3dlYl9oZGZzX3NlbnNvci5weQ==) | `100% <100%> (+50%)` | :arrow_up: |
| ... and [77 more](https://codecov.io/gh/apache/airflow/pull/7142/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=footer). Last update [d654d69...5be5384](https://codecov.io/gh/apache/airflow/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7142: [AIRFLOW-6539][AIP-21]
Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7142:
[AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7142: [AIRFLOW-6539][AIP-21][WIP] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573383213
Is it still [WIP] ? Or should we merge it @mik-laj ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on issue #7142: [AIRFLOW-6539][AIP-21]
Move Apache classes to providers.apache package
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7142: [AIRFLOW-6539][AIP-21] Move Apache classes to providers.apache package
URL: https://github.com/apache/airflow/pull/7142#issuecomment-573400868
I found an issue:. We have HDFS sensor in two places:
https://github.com/apache/airflow/blob/master/airflow/contrib/sensors/hdfs_sensor.py
https://github.com/apache/airflow/blob/master/airflow/sensors/hdfs_sensor.py
but in this PR we have sensors from one location, because the file has been overwritten instead of the appended.
You could verify this PR using following commands:
```
diff <(git show apache/master:airflow/contrib/hooks/pinot_hook.py) <(cat airflow/providers/apache/pinot/hooks/pinot.py)
diff <(git show apache/master:tests/contrib/hooks/test_pinot_hook.py) <(cat tests/providers/apache/pinot/hooks/test_pinot.py)
diff <(git show apache/master:airflow/contrib/hooks/spark_jdbc_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_jdbc.py)
diff <(git show apache/master:tests/contrib/hooks/test_spark_jdbc_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_jdbc.py)
diff <(git show apache/master:airflow/contrib/hooks/spark_jdbc_script.py) <(cat airflow/providers/apache/spark/hooks/spark_jdbc_script.py)
diff <(git show apache/master:airflow/contrib/hooks/spark_sql_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_sql.py)
diff <(git show apache/master:tests/contrib/hooks/test_spark_sql_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_sql.py)
diff <(git show apache/master:airflow/contrib/hooks/spark_submit_hook.py) <(cat airflow/providers/apache/spark/hooks/spark_submit.py)
diff <(git show apache/master:tests/contrib/hooks/test_spark_submit_hook.py) <(cat tests/providers/apache/spark/hooks/test_spark_submit.py)
diff <(git show apache/master:airflow/contrib/hooks/sqoop_hook.py) <(cat airflow/providers/apache/sqoop/hooks/sqoop.py)
diff <(git show apache/master:tests/contrib/hooks/test_sqoop_hook.py) <(cat tests/providers/apache/sqoop/hooks/test_sqoop.py)
diff <(git show apache/master:airflow/contrib/operators/druid_operator.py) <(cat airflow/providers/apache/druid/operators/druid.py)
diff <(git show apache/master:tests/contrib/operators/test_druid_operator.py) <(cat tests/providers/apache/druid/operators/test_druid.py)
diff <(git show apache/master:airflow/contrib/operators/spark_jdbc_operator.py) <(cat airflow/providers/apache/spark/operators/spark_jdbc.py)
diff <(git show apache/master:tests/contrib/operators/test_spark_jdbc_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_jdbc.py)
diff <(git show apache/master:airflow/contrib/operators/spark_sql_operator.py) <(cat airflow/providers/apache/spark/operators/spark_sql.py)
diff <(git show apache/master:tests/contrib/operators/test_spark_sql_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_sql.py)
diff <(git show apache/master:airflow/contrib/operators/spark_submit_operator.py) <(cat airflow/providers/apache/spark/operators/spark_submit.py)
diff <(git show apache/master:tests/contrib/operators/test_spark_submit_operator.py) <(cat tests/providers/apache/spark/operators/test_spark_submit.py)
diff <(git show apache/master:airflow/contrib/operators/sqoop_operator.py) <(cat airflow/providers/apache/sqoop/operators/sqoop.py)
diff <(git show apache/master:tests/contrib/operators/test_sqoop_operator.py) <(cat tests/providers/apache/sqoop/operators/test_sqoop.py)
diff <(git show apache/master:airflow/contrib/sensors/hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/hdfs.py)
diff <(git show apache/master:tests/contrib/sensors/test_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_hdfs.py)
diff <(git show apache/master:airflow/hooks/druid_hook.py) <(cat airflow/providers/apache/druid/hooks/druid.py)
diff <(git show apache/master:tests/hooks/test_druid_hook.py) <(cat tests/providers/apache/druid/hooks/test_druid.py)
diff <(git show apache/master:airflow/hooks/hdfs_hook.py) <(cat airflow/providers/apache/hdfs/hooks/hdfs.py)
diff <(git show apache/master:tests/hooks/test_hdfs_hook.py) <(cat tests/providers/apache/hdfs/hooks/test_hdfs.py)
diff <(git show apache/master:airflow/hooks/hive_hooks.py) <(cat airflow/providers/apache/hive/hooks/hive.py)
diff <(git show apache/master:tests/hooks/test_hive_hook.py) <(cat tests/providers/apache/hive/hooks/test_hive.py)
diff <(git show apache/master:airflow/hooks/pig_hook.py) <(cat airflow/providers/apache/pig/hooks/pig.py)
diff <(git show apache/master:tests/hooks/test_pig_hook.py) <(cat tests/providers/apache/pig/hooks/test_pig.py)
diff <(git show apache/master:airflow/hooks/webhdfs_hook.py) <(cat airflow/providers/apache/hdfs/hooks/webhdfs.py)
diff <(git show apache/master:tests/hooks/test_webhdfs_hook.py) <(cat tests/providers/apache/hdfs/hooks/test_webhdfs.py)
diff <(git show apache/master:airflow/operators/druid_check_operator.py) <(cat airflow/providers/apache/druid/operators/druid_check.py)
diff <(git show apache/master:tests/operators/test_druid_check_operator.py) <(cat tests/providers/apache/druid/operators/test_druid_check.py)
diff <(git show apache/master:airflow/operators/hive_operator.py) <(cat airflow/providers/apache/hive/operators/hive.py)
diff <(git show apache/master:tests/operators/test_hive_operator.py) <(cat tests/providers/apache/hive/operators/test_hive.py)
diff <(git show apache/master:airflow/operators/hive_stats_operator.py) <(cat airflow/providers/apache/hive/operators/hive_stats.py)
diff <(git show apache/master:tests/operators/test_hive_stats_operator.py) <(cat tests/providers/apache/hive/operators/test_hive_stats.py)
diff <(git show apache/master:airflow/operators/pig_operator.py) <(cat airflow/providers/apache/pig/operators/pig.py)
diff <(git show apache/master:airflow/sensors/hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/hdfs.py)
diff <(git show apache/master:tests/sensors/test_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_hdfs.py)
diff <(git show apache/master:airflow/sensors/hive_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/hive_partition.py)
diff <(git show apache/master:tests/sensors/test_hive_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_hive_partition.py)
diff <(git show apache/master:airflow/sensors/metastore_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/metastore_partition.py)
diff <(git show apache/master:tests/sensors/test_metastore_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_metastore_partition.py)
diff <(git show apache/master:airflow/sensors/named_hive_partition_sensor.py) <(cat airflow/providers/apache/hive/sensors/named_hive_partition.py)
diff <(git show apache/master:tests/sensors/test_named_hive_partition_sensor.py) <(cat tests/providers/apache/hive/sensors/test_named_hive_partition.py)
diff <(git show apache/master:airflow/sensors/web_hdfs_sensor.py) <(cat airflow/providers/apache/hdfs/sensors/web_hdfs.py)
diff <(git show apache/master:tests/sensors/test_web_hdfs_sensor.py) <(cat tests/providers/apache/hdfs/sensors/test_web_hdfs.py)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services