You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2023/01/13 01:13:07 UTC
[GitHub] [iceberg] singhpk234 opened a new pull request, #6576: AWS: Fix check for isTableRegisteredWithLF check
singhpk234 opened a new pull request, #6576:
URL: https://github.com/apache/iceberg/pull/6576
Solves https://github.com/apache/iceberg/issues/6523
The check of isTableRegisteredWithLakeFormation is performed even before the table is created in glue when a create table command is called from spark hence resulting in failure, if the entity is not found then as per my understanding, we can assume the table is not enrolled in LF and hence should return false (need to double check with LF experts as my understanding of LF is a bit limited.
cc @jackye1995 @xiaoxuandev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 commented on pull request #6576: AWS: Fix check for isTableRegisteredWithLF leading to CREATE table failure
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on PR #6576:
URL: https://github.com/apache/iceberg/pull/6576#issuecomment-1382673430
did some more digging, posting what i found so far, this issue, is only observed in 0.14.x and 1.0.0 (and I directly tested my fix on top of master :sweat_smile:), 1.1.0 & master are fine, This is because starting 1.1.0 we now create a glue table (dummy table if the commit not succeeds, to be removed later) before writing s3 metadata files (which does the isTableEnroledinLF check, and now since the table is already created this check passes), prior to this the table creation use to happen after s3 write, which would result in failure.
This above behaviour makes sense considering that this pr should no longer be required atleast to the master (happy to create backport pr's for lower versions if required), hence closing this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] singhpk234 closed pull request #6576: AWS: Fix check for isTableRegisteredWithLF leading to CREATE table failure
Posted by GitBox <gi...@apache.org>.
singhpk234 closed pull request #6576: AWS: Fix check for isTableRegisteredWithLF leading to CREATE table failure
URL: https://github.com/apache/iceberg/pull/6576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #6576: AWS: Fix check for isTableRegisteredWithLF leading to CREATE table failure
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on PR #6576:
URL: https://github.com/apache/iceberg/pull/6576#issuecomment-1382243877
@xiaoxuandev can you take a look? I believe this case should have been covered in unit test, need to take a deeper look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org