You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/09/17 04:50:30 UTC
[kudu-CR] [util] update on DirName() on BSD-derived system
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16467
Change subject: [util] update on DirName() on BSD-derived system
......................................................................
[util] update on DirName() on BSD-derived system
This is a follow-up to e201c15715834f925624463a7ccac8d59c3464eb.
Change-Id: Ic70ea96640d281bda372bd54c7d67bb1a59e0a8b
---
M src/kudu/util/path_util.cc
1 file changed, 13 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/16467/1
--
To view, visit http://gerrit.cloudera.org:8080/16467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic70ea96640d281bda372bd54c7d67bb1a59e0a8b
Gerrit-Change-Number: 16467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] update on DirName() on BSD-derived system
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16467 )
Change subject: [util] update on DirName() on BSD-derived system
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70ea96640d281bda372bd54c7d67bb1a59e0a8b
Gerrit-Change-Number: 16467
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Sep 2020 20:19:28 +0000
Gerrit-HasComments: No
[kudu-CR] [util] update on DirName() on BSD-derived system
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16467 )
Change subject: [util] update on DirName() on BSD-derived system
......................................................................
[util] update on DirName() on BSD-derived system
This is a follow-up to e201c15715834f925624463a7ccac8d59c3464eb.
Change-Id: Ic70ea96640d281bda372bd54c7d67bb1a59e0a8b
Reviewed-on: http://gerrit.cloudera.org:8080/16467
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/util/path_util.cc
1 file changed, 13 insertions(+), 7 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16467
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70ea96640d281bda372bd54c7d67bb1a59e0a8b
Gerrit-Change-Number: 16467
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)