You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:36:02 UTC

[GitHub] [pulsar] HQebupt opened a new pull request, #17668: [fix][managed-ledger]persistentMarkDeletePosition is ahead of markDeletePosition in ManagedCursor when handle seek request

HQebupt opened a new pull request, #17668:
URL: https://github.com/apache/pulsar/pull/17668

   ### Motivation
   When the client seek a position, it will update the read posistion and mark delete position in the cursor. And meanwhile, it will persist the mark delete position to Bookie, then record the persistent mark delete position in the field `persistentMarkDeletePosition`. 
   
   However, The persistent mark delete position `persistentMarkDeletePosition` is ahead of `markDeletePosition` after seek , which is obviously unreasonable.
   
   https://github.com/apache/pulsar/blob/cbbcd41cfc80793cf025ef98390339395ecd48ac/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java#L125-L132
   
   ### Modifications
   - Persistent the previous seek position as new persistent mark delete position into Bookie.
   - Clean up code
   
   ### Verifying this change
   
   - [x]  Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   ### Does this pull request potentially affect one of the following parts:
   
   If `yes` was chosen, please highlight the changes
   
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API: (no)
   - The schema: (no)
   - The default values of configurations: (no)
   - The wire protocol: (no)
   - The rest endpoints: (no)
   - The admin cli options: (no)
   - Anything that affects deployment: (no)
   
   ### Documentation
   Check the box below and label this PR (if you have committer privilege).
   
   Need to update docs? 
   - [x] `doc-not-needed` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt closed pull request #17668: [fix][ml]persistentMarkDeletePosition is ahead of markDeletePosition in ManagedCursor when handling seek request

Posted by GitBox <gi...@apache.org>.
HQebupt closed pull request #17668: [fix][ml]persistentMarkDeletePosition is ahead of markDeletePosition in ManagedCursor when handling seek request
URL: https://github.com/apache/pulsar/pull/17668


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #17668: [fix][managed-ledger]persistentMarkDeletePosition is ahead of markDeletePosition in ManagedCursor when handling seek request

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17668:
URL: https://github.com/apache/pulsar/pull/17668#issuecomment-1283714229

   @eolivelli @Technoboy- @AnonHxy @Jason918 @codelipenghui PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #17668: [fix][ml]persistentMarkDeletePosition is ahead of markDeletePosition in ManagedCursor when handling seek request

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17668:
URL: https://github.com/apache/pulsar/pull/17668#issuecomment-1297979595

   Duplicated with #18237 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org