[GitHub] [avro] KalleOlaviNiemitalo commented on a diff in pull request #1736: AVRO-3547: Add support for custom attributes in Avro Schema

[GitBox <gi...@apache.org>]

KalleOlaviNiemitalo commented on code in PR #1736:
URL: https://github.com/apache/avro/pull/1736#discussion_r924144410


##########
lang/c++/impl/Compiler.cc:
##########
@@ -146,7 +149,8 @@ struct Field {
     const string name;
     const NodePtr schema;
     const GenericDatum defaultValue;
-    Field(string n, NodePtr v, GenericDatum dv) : name(std::move(n)), schema(std::move(v)), defaultValue(std::move(dv)) {}
+    const CustomFields customFields;
+    Field(string n, NodePtr v, GenericDatum dv, const CustomFields& cf) : name(std::move(n)), schema(std::move(v)), defaultValue(std::move(dv)), customFields(std::move(cf)) {}

Review Comment:
   std::move(cf) here seems odd because cf is a const&. But I guess it'll just make a const&& and not cause any problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org