You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Paul Foxworthy (JIRA)" <ji...@apache.org> on 2015/07/07 02:36:04 UTC
[jira] [Updated] (OFBIZ-4365) Verify Pick ignores ship
group/picklist bin
[ https://issues.apache.org/jira/browse/OFBIZ-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Foxworthy updated OFBIZ-4365:
----------------------------------
Description:
Even though the Verify Pick screen prompts for the shipping group sequence ID or the picklist bin ID, the completeVerifiedPick service ignores this information. Rather, completeVerifiedPick looks at all items in the order. The result is that any outstanding ship group prevents a verify on a separate ship group which is ready to pick and ship.
The attached patch fixes this issue, but I would appreciate some review on all this. It's possible I haven't understood everything about the design of Verify Pick.
- The completeVerifiedPick service is defined with a shipGroupSeqId parameter, but that parameter is not used in the method that implements the service, namely completeVerifiedPick in VerifyPickServices. Why not?
See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickServices.java?hb=true#to86
- The VerifyPickSession class remembers the picklist bin if you've chosen to enter one, but doesn't remember the shipGroupSeqId if you chose to enter that. Why not?
See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java?r=935487#to52
was:
Even though the Verify Pick screen prompts for the shipping group sequence ID or the picklist bin ID, the completeVerifiedPick service ignores this information. Rather, completeVerifiedPick looks at all items in the order. The result is that any outstanding ship group prevents a verify on a separate ship group which is ready to pick and ship.
The attached patch fixes this issue, but I would appreciate some review on all this. It's possible I haven't understood everything about the design of Verify Pick.
- The completeVerifiedPick service is defined with a shipGroupSeqId parameter, but that parameter is not used in the method that implements the service, namely completeVerifiedPick in VeryPickServices. Why not?
See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickServices.java?hb=true#to86
- The VerifyPickSession class remembers the picklist bin if you've chosen to enter one, but doesn't remember the shipGroupSeqId if you chose to enter that. Why not?
See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java?r=935487#to52
> Verify Pick ignores ship group/picklist bin
> -------------------------------------------
>
> Key: OFBIZ-4365
> URL: https://issues.apache.org/jira/browse/OFBIZ-4365
> Project: OFBiz
> Issue Type: Bug
> Components: product
> Affects Versions: Trunk
> Environment: revision 1156416
> Reporter: Paul Foxworthy
> Assignee: Ashish Vijaywargiya
> Attachments: OFBIZ-4365_VerifyPick.patch
>
>
> Even though the Verify Pick screen prompts for the shipping group sequence ID or the picklist bin ID, the completeVerifiedPick service ignores this information. Rather, completeVerifiedPick looks at all items in the order. The result is that any outstanding ship group prevents a verify on a separate ship group which is ready to pick and ship.
> The attached patch fixes this issue, but I would appreciate some review on all this. It's possible I haven't understood everything about the design of Verify Pick.
> - The completeVerifiedPick service is defined with a shipGroupSeqId parameter, but that parameter is not used in the method that implements the service, namely completeVerifiedPick in VerifyPickServices. Why not?
> See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickServices.java?hb=true#to86
> - The VerifyPickSession class remembers the picklist bin if you've chosen to enter one, but doesn't remember the shipGroupSeqId if you chose to enter that. Why not?
> See https://fisheye6.atlassian.com/browse/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java?r=935487#to52
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)