You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/26 07:41:41 UTC
Review Request 67738: Renamed APR and SVN `find_package`
implementations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67738/
-----------------------------------------------------------
Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
Repository: mesos
Description
-------
Upstream follows a convention of using ALL UPERCASE letters for
package names for implementations of `FindPACKAGE.cmake`. This patch
renames our `find_package` implementations fro APR and SVN.
Diffs
-----
3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c
3rdparty/stout/cmake/FindApr.cmake
3rdparty/stout/cmake/FindSvn.cmake
Diff: https://reviews.apache.org/r/67738/diff/1/
Testing
-------
* fresh build works
* rebuild works, `ninja clean && ninja tests`, `ninja tests`
Thanks,
Benjamin Bannier
Re: Review Request 67738: Renamed APR and SVN `find_package`
implementations.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67738/#review205388
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Schwartzmeyer
On June 26, 2018, 12:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67738/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 12:41 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upstream follows a convention of using ALL UPERCASE letters for
> package names for implementations of `FindPACKAGE.cmake`. This patch
> renames our `find_package` implementations fro APR and SVN.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c
> 3rdparty/stout/cmake/FindApr.cmake
> 3rdparty/stout/cmake/FindSvn.cmake
>
>
> Diff: https://reviews.apache.org/r/67738/diff/1/
>
>
> Testing
> -------
>
> * fresh build works
> * rebuild works, `ninja clean && ninja tests`, `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67738: Renamed APR and SVN `find_package`
implementations.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On June 26, 2018, 2:21 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Failed to apply the current review.
> >
> > Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67738`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67738
> >
> > Relevant logs:
> >
> > - [apply-review-67738-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67738/logs/apply-review-67738-stdout.log):
> >
> > ```
> > error: 3rdparty/stout/cmake/FindAPR.cmake: already exists in working directory
> > error: 3rdparty/stout/cmake/FindSVN.cmake: already exists in working directory
> > ```
HAHAHA case-insensitive file-systems. Safe to ignore.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67738/#review205357
-----------------------------------------------------------
On June 26, 2018, 12:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67738/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 12:41 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upstream follows a convention of using ALL UPERCASE letters for
> package names for implementations of `FindPACKAGE.cmake`. This patch
> renames our `find_package` implementations fro APR and SVN.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c
> 3rdparty/stout/cmake/FindApr.cmake
> 3rdparty/stout/cmake/FindSvn.cmake
>
>
> Diff: https://reviews.apache.org/r/67738/diff/1/
>
>
> Testing
> -------
>
> * fresh build works
> * rebuild works, `ninja clean && ninja tests`, `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67738: Renamed APR and SVN `find_package`
implementations.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67738/#review205357
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\python3\apply-reviews.py -n -r 67738`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67738
Relevant logs:
- [apply-review-67738-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67738/logs/apply-review-67738-stdout.log):
```
error: 3rdparty/stout/cmake/FindAPR.cmake: already exists in working directory
error: 3rdparty/stout/cmake/FindSVN.cmake: already exists in working directory
```
- Mesos Reviewbot Windows
On June 26, 2018, 7:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67738/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:41 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upstream follows a convention of using ALL UPERCASE letters for
> package names for implementations of `FindPACKAGE.cmake`. This patch
> renames our `find_package` implementations fro APR and SVN.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c
> 3rdparty/stout/cmake/FindApr.cmake
> 3rdparty/stout/cmake/FindSvn.cmake
>
>
> Diff: https://reviews.apache.org/r/67738/diff/1/
>
>
> Testing
> -------
>
> * fresh build works
> * rebuild works, `ninja clean && ninja tests`, `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 67738: Renamed APR and SVN `find_package`
implementations.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67738/#review205365
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67738]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 26, 2018, 7:41 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67738/
> -----------------------------------------------------------
>
> (Updated June 26, 2018, 7:41 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Upstream follows a convention of using ALL UPERCASE letters for
> package names for implementations of `FindPACKAGE.cmake`. This patch
> renames our `find_package` implementations fro APR and SVN.
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c
> 3rdparty/stout/cmake/FindApr.cmake
> 3rdparty/stout/cmake/FindSvn.cmake
>
>
> Diff: https://reviews.apache.org/r/67738/diff/1/
>
>
> Testing
> -------
>
> * fresh build works
> * rebuild works, `ninja clean && ninja tests`, `ninja tests`
>
>
> Thanks,
>
> Benjamin Bannier
>
>