[GitHub] [hudi] danny0405 commented on a diff in pull request #8945: [HUDI-6360]spark-memory parmater should not be forced to be true

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #8945:
URL: https://github.com/apache/hudi/pull/8945#discussion_r1228874997


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieClusteringJob.java:
##########
@@ -87,7 +87,7 @@ public static class Config implements Serializable {
     public int parallelism = 1;
     @Parameter(names = {"--spark-master", "-ms"}, description = "Spark master")
     public String sparkMaster = null;
-    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory to use", required = true)
+    @Parameter(names = {"--spark-memory", "-sm"}, description = "spark memory to use", required = false)
     public String sparkMemory = null;

Review Comment:
   Not very familiar with Spark, what is the behavior when default memory is not suffient for job execution then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org