[GitHub] [singa] chrishkchris edited a comment on issue #589: bugfix on dev branch: cpu batchnnorm num of args does not match

[GitBox <gi...@apache.org>]

chrishkchris edited a comment on issue #589: bugfix on dev branch: cpu batchnnorm num of args does not match
URL: https://github.com/apache/singa/pull/589#issuecomment-583813389
 
 
   There is an new error in cpu batchnorm, where the number of output arguments do not match with the python autograd code. This PR simply fix the issue.
   
   ```
   root@b8dfa5473dea:~/dcsysh/singa/test/python# python3 test_operation.py
   ................................................................E............................................................
   ======================================================================
   ERROR: test_batchnorm2d_cpu (__main__.TestPythonOperation)
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "test_operation.py", line 286, in test_batchnorm2d_cpu
       y = batchnorm_0(cpu_input_tensor)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1502, in __call__
       self.running_var,
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1581, in batchnorm_2d
       return _BatchNorm2d(handle, running_mean, running_var)(x, scale, bias)[0]
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 244, in __call__
       return self._do_forward(*xs)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 294, in _do_forward
       ys = self.forward(*xs)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1532, in forward
       self.running_var)
   ValueError: too many values to unpack (expected 3)
   
   ----------------------------------------------------------------------
   Ran 125 tests in 0.766s
   
   FAILED (errors=1)
   
   root@b8dfa5473dea:~/dcsysh/singa/examples/autograd# python3 resnet.py
   Start intialization............
     0%|                                                                                                                                                                                  | 0/100 [00:26<?, ?it/s]
   Traceback (most recent call last):
     File "resnet.py", line 278, in <module>
       x = model(tx)
     File "resnet.py", line 179, in __call__
       x = self.bn1(x)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1502, in __call__
       self.running_var,
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1581, in batchnorm_2d
       return _BatchNorm2d(handle, running_mean, running_var)(x, scale, bias)[0]
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 244, in __call__
       return self._do_forward(*xs)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 294, in _do_forward
       ys = self.forward(*xs)
     File "/root/dcsysh/singa/build/python/singa/autograd.py", line 1532, in forward
       self.running_var)
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services