You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "SLSJL (via GitHub)" <gi...@apache.org> on 2023/12/25 04:38:04 UTC
[PR] Remove the Incubation description [eventmesh-site]
SLSJL opened a new pull request, #165:
URL: https://github.com/apache/eventmesh-site/pull/165
1. Remove the incubation description from the footer
2. Add the Apache logo on the footer area
3. Remove the incubation-related copyrights from the page bottom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] Remove the Incubation description [eventmesh-site]
Posted by "SLSJL (via GitHub)" <gi...@apache.org>.
SLSJL commented on PR #165:
URL: https://github.com/apache/eventmesh-site/pull/165#issuecomment-1869246489
Close to amend the PR title and the source of the Apache logo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Remove the Incubation description [eventmesh-site]
Posted by "SLSJL (via GitHub)" <gi...@apache.org>.
SLSJL commented on PR #165:
URL: https://github.com/apache/eventmesh-site/pull/165#issuecomment-1869245757
> LGTM, Good Job! Please add `Fixes #162` in the text~
Ok, will close this request and submit a new one soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Remove the Incubation description [eventmesh-site]
Posted by "SLSJL (via GitHub)" <gi...@apache.org>.
SLSJL closed pull request #165: Remove the Incubation description
URL: https://github.com/apache/eventmesh-site/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] Remove the Incubation description [eventmesh-site]
Posted by "SLSJL (via GitHub)" <gi...@apache.org>.
SLSJL commented on code in PR #165:
URL: https://github.com/apache/eventmesh-site/pull/165#discussion_r1436231819
##########
src/theme/Footer/index.tsx:
##########
@@ -78,37 +77,41 @@ function Footer(): JSX.Element | null {
<div className="container">
{links && links.length > 0 && (
<div className="row footer__links">
- {links.map((linkItem, i) => (
- <div key={i} className="col footer__col">
- {linkItem.title != null ? (
- <div className="footer__title">{linkItem.title}</div>
- ) : null}
- {linkItem.items != null
- && Array.isArray(linkItem.items)
- && linkItem.items.length > 0 ? (
- <ul className="footer__items">
- {linkItem.items.map((item, key) => (item.html ? (
- <li
- key={key}
- className="footer__item"
- // Developer provided the HTML, so assume it's safe.
- // eslint-disable-next-line react/no-danger
- dangerouslySetInnerHTML={{
- __html: item.html,
- }}
- />
- ) : (
- <li key={item.href || item.to} className="footer__item">
- <FooterLink {...item} />
- </li>
- )))}
- </ul>
+ <div className="col footer__col">
+ <img src='https://doris.apache.org/images/asf_logo_apache.svg' />
Review Comment:
Good spot, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Remove the Incubation description [eventmesh-site]
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #165:
URL: https://github.com/apache/eventmesh-site/pull/165#discussion_r1436028027
##########
src/theme/Footer/index.tsx:
##########
@@ -78,37 +77,41 @@ function Footer(): JSX.Element | null {
<div className="container">
{links && links.length > 0 && (
<div className="row footer__links">
- {links.map((linkItem, i) => (
- <div key={i} className="col footer__col">
- {linkItem.title != null ? (
- <div className="footer__title">{linkItem.title}</div>
- ) : null}
- {linkItem.items != null
- && Array.isArray(linkItem.items)
- && linkItem.items.length > 0 ? (
- <ul className="footer__items">
- {linkItem.items.map((item, key) => (item.html ? (
- <li
- key={key}
- className="footer__item"
- // Developer provided the HTML, so assume it's safe.
- // eslint-disable-next-line react/no-danger
- dangerouslySetInnerHTML={{
- __html: item.html,
- }}
- />
- ) : (
- <li key={item.href || item.to} className="footer__item">
- <FooterLink {...item} />
- </li>
- )))}
- </ul>
+ <div className="col footer__col">
+ <img src='https://doris.apache.org/images/asf_logo_apache.svg' />
Review Comment:
Would it be more appropriate to upload this image to EventMesh's own site and then use EventMesh's URL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org