You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/26 16:52:34 UTC
[GitHub] [airflow] potiuk opened a new pull request #18536: Check docker-compose version in breeze
potiuk opened a new pull request #18536:
URL: https://github.com/apache/airflow/pull/18536
We started to use some newer features in docker-compose of breeze.
They are new enough (May 2020) that older versions of
docker-compose do not work with them.
This PR checks if the docker-compose is >= 1.29
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929699410
We already have one version check for Docker compose. Can we update it?
https://github.com/apache/airflow/blob/ab7acfd7df25cd1a4c739bf99186267356f1eda6/breeze#L595-L609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929948329
> We already have one version check for Docker compose. Can we update it?
>
> https://github.com/apache/airflow/blob/ab7acfd7df25cd1a4c739bf99186267356f1eda6/breeze#L595-L609
Yeah. I totally forgot about it :). The message from Felix this morning reminde me about it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929699410
We already have one version check for Docker compose. Can we update it?
https://github.com/apache/airflow/blob/ab7acfd7df25cd1a4c739bf99186267356f1eda6/breeze#L595-L609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929948329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18536:
URL: https://github.com/apache/airflow/pull/18536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-930064443
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-930064443
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929699410
We already have one version check for Docker compose. Can we update it?
https://github.com/apache/airflow/blob/ab7acfd7df25cd1a4c739bf99186267356f1eda6/breeze#L596-L609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-930128415
New version with removed check for v2 (As it seems https://github.com/docker/compose-cli/issues/1917 is alredy fixed in latest two release candidates). It would be awesome @feluelle @mik-laj if you could check it with both "disable-v2" and "enable-v2"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18536:
URL: https://github.com/apache/airflow/pull/18536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929699410
We already have one version check for Docker compose. Can we update it?
https://github.com/apache/airflow/blob/ab7acfd7df25cd1a4c739bf99186267356f1eda6/breeze#L596-L609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18536: Check docker-compose version in breeze
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18536:
URL: https://github.com/apache/airflow/pull/18536#issuecomment-929329408
BTW. Can someone check if it works on Mac as well? Especialy with latest docker compose which is built-in in docker in latest Docker Desktop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org