You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Roman Coedo <no...@github.com> on 2014/06/17 12:43:08 UTC
[jclouds-labs-aws] JCLOUDS-457: Changed the ArrayLists in TreeHash
util to ImmutableLists. (#14)
You can merge this Pull Request by running:
git pull https://github.com/rcoedo/jclouds-labs-aws treehasher
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs-aws/pull/14
-- Commit Summary --
* JCLOUDS-457: Changed the ArrayLists in TreeHash util to ImmutableLists.
-- File Changes --
M glacier/src/main/java/org/jclouds/glacier/util/TreeHash.java (15)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-aws/pull/14.patch
https://github.com/jclouds/jclouds-labs-aws/pull/14.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/14
Re: [jclouds-labs-aws] JCLOUDS-457: Changed the ArrayLists in
TreeHash util to ImmutableLists. (#14)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-aws-pull-requests #29](https://jclouds.ci.cloudbees.com/job/jclouds-labs-aws-pull-requests/29/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/14#issuecomment-46292369
Re: [jclouds-labs-aws] JCLOUDS-457: Changed the ArrayLists in
TreeHash util to ImmutableLists. (#14)
Posted by Andrew Gaul <no...@github.com>.
> @@ -79,7 +78,7 @@ public String toString() {
> private static final int CHUNK_SIZE = 1024 * 1024;
>
> private static HashCode hashList(Collection<HashCode> hashList) {
> - List<HashCode> result = Lists.newArrayList();
> + Builder<HashCode> result = ImmutableList.<HashCode>builder();
I removed the unnecessary second generic signature which Java infers.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/14/files#r13878908
Re: [jclouds-labs-aws] JCLOUDS-457: Changed the ArrayLists in
TreeHash util to ImmutableLists. (#14)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds-labs-aws #968](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-aws/968/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-aws/pull/14#issuecomment-46292413