You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "hqhq1025 (via GitHub)" <gi...@apache.org> on 2026/08/23 15:34:35 UTC
[PR] fix(desktop): make queued messages editable [maka]
hqhq1025 opened a new pull request, #3635:
URL: https://github.com/apache/maka/pull/3635
## Summary
- keep queued steering messages visible until the active turn actually consumes them, while filtering entries already in flight
- align the pending-message plate with Codex by exposing Edit, Steer, Delete, and follow-up reordering
- add an authoritative `queue.entry.update` Runtime Host command that preserves entry identity, order, and placement
- re-prepare edited content, relocate valid inline references, and reject stale edits with the queue revision
## Root cause
The desktop rendered only follow-up entries from `queue_update`, so queued steering messages disappeared before delivery. Editing was implemented as retracting an entry back into the composer, which changed the queue semantics and could not preserve its original position or placement.
This change keeps the Runtime Host projection as the source of truth and adds a dedicated compare-and-swap update operation.
## Verification
- `npm run build`
- `npm run typecheck`
- `npm run lint -- --diagnostic-level=error`
- `npm run format:check`
- Runtime Host protocol and message coordinator tests: 83 passed
- Runtime session manager tests: 223 passed
- Desktop queue/client/IPC tests: 36 passed
- Composer queue tests: 4 passed
- Storybook desktop and mobile visual checks for pending and editing states
- `npm run check:asf-headers` still reports the two pre-existing missing headers in `packages/cli/src/tui-session-status.ts` and `packages/cli/src/__tests__/tui-session-status.test.ts`
## Screenshots
Before and after screenshots will be attached immediately after opening the PR.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: Codex (GPT-5.6) implemented the Runtime Host, desktop bridge, UI, tests, and visual verification.
## Checklist
- [x] Tests cover the change and fail without it
- [x] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): make queued messages editable [maka]
Posted by "hqhq1025 (via GitHub)" <gi...@apache.org>.
hqhq1025 merged PR #3635:
URL: https://github.com/apache/maka/pull/3635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org