You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@wandisco.com> on 2010/01/28 14:40:15 UTC
Commit failure via out of date proxy - issue #3561 - with Serf
On Wed, 2010-01-20, Julian Foad wrote:
> I have added issue #3561
> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to track this
Just now, using a client built from today's trunk code, I got the same
problem when committing with Serf:
[[[
$ svn ci -F n-o.patch subversion/libsvn_fs_base/
/.../subversion/svn/commit-cmd.c:142: (apr_err=190003)
/.../subversion/libsvn_client/commit.c:853: (apr_err=190003)
svn: Commit failed (details follow):
/.../subversion/libsvn_client/commit_util.c:1634: (apr_err=190003)
/.../subversion/libsvn_delta/path_driver.c:173: (apr_err=190003)
/.../subversion/libsvn_ra_serf/commit.c:1246: (apr_err=190003)
/.../subversion/libsvn_ra_serf/util.c:596: (apr_err=190003)
/.../subversion/libsvn_ra_serf/util.c:738: (apr_err=190003)
svn: The specified baseline is not the latest baseline, so it may not be checked out.
$ svn ci -F n-o.patch subversion/libsvn_fs_base/
Sending subversion/libsvn_fs_base/dag.c
Sending subversion/libsvn_fs_base/dag.h
Sending subversion/libsvn_fs_base/node-rev.h
Sending subversion/libsvn_fs_base/util/fs_skels.h
Transmitting file data ....
Committed revision 904095.
$ svn --version
svn, version 1.7.0 (dev build)
compiled Jan 28 2010, 14:21:13
Copyright (C) 2010 The Apache Software Foundation.
This software consists of contributions made by many people;
see the NOTICE file for more information.
Subversion is open source software, see http://subversion.apache.org/
The following repository access (RA) modules are available:
* ra_neon : Module for accessing a repository via WebDAV protocol using Neon.
- handles 'http' scheme
- handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network protocol.
- with Cyrus SASL authentication
- handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
- handles 'file' scheme
* ra_serf : Module for accessing a repository via WebDAV protocol using serf.
- handles 'http' scheme
- handles 'https' scheme
]]]
In earlier emails [1] and [2], Kamesh indicated that Serf does not
suffer the same problem because it does not issue the PROPFIND, but that
was in the context of Mike asking about HTTPv2, so I am not clear
whether that applies to an ordinary build or if I have to do something
special to use HTTPv2.
- Julian
[1]
<http://mail-archives.apache.org/mod_mbox/subversion-dev/201001.mbox/ajax/%3c0213965108DEAD48960CE83455E07DFF0192BB68@maa-exchmb.maa.corp.collab.net%3e>
[2]
<http://mail-archives.apache.org/mod_mbox/subversion-dev/201001.mbox/ajax/%3c4B45EC6A.5050907@collab.net%3e>
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Mon, Feb 1, 2010 at 9:02 AM, Julian Foad <ju...@wandisco.com> wrote:
>> > Committed this patch at r905326.
>>
>> Xlnt. Thanks, Kamesh.
>
> Ah, my favourite kind of bug fix: *removing* a bunch of code (and adding
> one line instead).
Sweet. =) -- justin
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by "C. Michael Pilato" <cm...@collab.net>.
>> Right. Now, that said, it might be prudent to make the same fix in Serf's
>> non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an easy
>> client-side fix to be had, seems silly to require a server upgrade instead.
>>
>> Kamesh, can you look into this?
>>
>>
> Attached patch fixes it, though I need to get better context to the
> relevant code base to give a 100% confident fix, which I will do it sooner.
I assume that printf() isn't part of the intended patch? :-)
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by Julian Foad <ju...@wandisco.com>.
On Mon, 2010-02-01 at 11:40 -0500, C. Michael Pilato wrote:
> Kamesh Jayachandran wrote:
> >>> Right. Now, that said, it might be prudent to make the same fix in Serf's
> >>> non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an easy
> >>> client-side fix to be had, seems silly to require a server upgrade
> >>> instead.
> >>>
> >>> Kamesh, can you look into this?
> >>>
> >> Attached patch fixes it, though I need to get better context to the
> >> relevant code base to give a 100% confident fix, which I will do it
> >> sooner.
> >>
> >> With regards
> >> Kamesh Jayachandran
> >>
> > Committed this patch at r905326.
>
> Xlnt. Thanks, Kamesh.
Ah, my favourite kind of bug fix: *removing* a bunch of code (and adding
one line instead).
Thanks.
- Julian
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by "C. Michael Pilato" <cm...@collab.net>.
Kamesh Jayachandran wrote:
>>> Right. Now, that said, it might be prudent to make the same fix in Serf's
>>> non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an easy
>>> client-side fix to be had, seems silly to require a server upgrade
>>> instead.
>>>
>>> Kamesh, can you look into this?
>>>
>> Attached patch fixes it, though I need to get better context to the
>> relevant code base to give a 100% confident fix, which I will do it
>> sooner.
>>
>> With regards
>> Kamesh Jayachandran
>>
> Committed this patch at r905326.
Xlnt. Thanks, Kamesh.
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by Kamesh Jayachandran <ka...@collab.net>.
On 01/29/2010 04:18 PM, Kamesh Jayachandran wrote:
> On 01/28/2010 09:08 PM, C. Michael Pilato wrote:
>> Julian Foad wrote:
>>> On Thu, 2010-01-28 at 10:23 -0500, C. Michael Pilato wrote:
>>>> Julian Foad wrote:
>>>>> On Wed, 2010-01-20, Julian Foad wrote:
>>>>>> I have added issue #3561
>>>>>> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to
>>>>>> track this
>>>>> Just now, using a client built from today's trunk code, I got the
>>>>> same
>>>>> problem when committing with Serf:
>>>> [...]
>>>>
>>>>> In earlier emails [1] and [2], Kamesh indicated that Serf does not
>>>>> suffer the same problem because it does not issue the PROPFIND,
>>>>> but that
>>>>> was in the context of Mike asking about HTTPv2, so I am not clear
>>>>> whether that applies to an ordinary build or if I have to do
>>>>> something
>>>>> special to use HTTPv2.
>>>> You have to have a server that supports HTTPv2. The ASF server is
>>>> not such
>>>> a server (because we haven't released Subversion 1.7 yet).
>>> Ah, thanks. So when it's upgraded, that part of the problem will be
>>> solved too. That's good.
>> Right. Now, that said, it might be prudent to make the same fix in
>> Serf's
>> non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an
>> easy
>> client-side fix to be had, seems silly to require a server upgrade
>> instead.
>>
>> Kamesh, can you look into this?
>>
> Attached patch fixes it, though I need to get better context to the
> relevant code base to give a 100% confident fix, which I will do it
> sooner.
>
> With regards
> Kamesh Jayachandran
>
Committed this patch at r905326.
With regards
Kamesh Jayachandran
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by Kamesh Jayachandran <ka...@collab.net>.
On 01/28/2010 09:08 PM, C. Michael Pilato wrote:
> Julian Foad wrote:
>
>> On Thu, 2010-01-28 at 10:23 -0500, C. Michael Pilato wrote:
>>
>>> Julian Foad wrote:
>>>
>>>> On Wed, 2010-01-20, Julian Foad wrote:
>>>>
>>>>> I have added issue #3561
>>>>> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to track this
>>>>>
>>>> Just now, using a client built from today's trunk code, I got the same
>>>> problem when committing with Serf:
>>>>
>>> [...]
>>>
>>>
>>>> In earlier emails [1] and [2], Kamesh indicated that Serf does not
>>>> suffer the same problem because it does not issue the PROPFIND, but that
>>>> was in the context of Mike asking about HTTPv2, so I am not clear
>>>> whether that applies to an ordinary build or if I have to do something
>>>> special to use HTTPv2.
>>>>
>>> You have to have a server that supports HTTPv2. The ASF server is not such
>>> a server (because we haven't released Subversion 1.7 yet).
>>>
>> Ah, thanks. So when it's upgraded, that part of the problem will be
>> solved too. That's good.
>>
> Right. Now, that said, it might be prudent to make the same fix in Serf's
> non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an easy
> client-side fix to be had, seems silly to require a server upgrade instead.
>
> Kamesh, can you look into this?
>
>
Attached patch fixes it, though I need to get better context to the
relevant code base to give a 100% confident fix, which I will do it sooner.
With regards
Kamesh Jayachandran
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by "C. Michael Pilato" <cm...@collab.net>.
Julian Foad wrote:
> On Thu, 2010-01-28 at 10:23 -0500, C. Michael Pilato wrote:
>> Julian Foad wrote:
>>> On Wed, 2010-01-20, Julian Foad wrote:
>>>> I have added issue #3561
>>>> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to track this
>>> Just now, using a client built from today's trunk code, I got the same
>>> problem when committing with Serf:
>> [...]
>>
>>> In earlier emails [1] and [2], Kamesh indicated that Serf does not
>>> suffer the same problem because it does not issue the PROPFIND, but that
>>> was in the context of Mike asking about HTTPv2, so I am not clear
>>> whether that applies to an ordinary build or if I have to do something
>>> special to use HTTPv2.
>> You have to have a server that supports HTTPv2. The ASF server is not such
>> a server (because we haven't released Subversion 1.7 yet).
>
> Ah, thanks. So when it's upgraded, that part of the problem will be
> solved too. That's good.
Right. Now, that said, it might be prudent to make the same fix in Serf's
non-HTTPv2 codepath that Kamesh made for Neon. I mean, if there's an easy
client-side fix to be had, seems silly to require a server upgrade instead.
Kamesh, can you look into this?
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by Julian Foad <ju...@wandisco.com>.
On Thu, 2010-01-28 at 10:23 -0500, C. Michael Pilato wrote:
> Julian Foad wrote:
> > On Wed, 2010-01-20, Julian Foad wrote:
> >> I have added issue #3561
> >> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to track this
> >
> > Just now, using a client built from today's trunk code, I got the same
> > problem when committing with Serf:
>
> [...]
>
> > In earlier emails [1] and [2], Kamesh indicated that Serf does not
> > suffer the same problem because it does not issue the PROPFIND, but that
> > was in the context of Mike asking about HTTPv2, so I am not clear
> > whether that applies to an ordinary build or if I have to do something
> > special to use HTTPv2.
>
> You have to have a server that supports HTTPv2. The ASF server is not such
> a server (because we haven't released Subversion 1.7 yet).
Ah, thanks. So when it's upgraded, that part of the problem will be
solved too. That's good.
- Julian
Re: Commit failure via out of date proxy - issue #3561 - with Serf
Posted by "C. Michael Pilato" <cm...@collab.net>.
Julian Foad wrote:
> On Wed, 2010-01-20, Julian Foad wrote:
>> I have added issue #3561
>> <http://subversion.tigris.org/issues/show_bug.cgi?id=3561> to track this
>
> Just now, using a client built from today's trunk code, I got the same
> problem when committing with Serf:
[...]
> In earlier emails [1] and [2], Kamesh indicated that Serf does not
> suffer the same problem because it does not issue the PROPFIND, but that
> was in the context of Mike asking about HTTPv2, so I am not clear
> whether that applies to an ordinary build or if I have to do something
> special to use HTTPv2.
You have to have a server that supports HTTPv2. The ASF server is not such
a server (because we haven't released Subversion 1.7 yet).
--
C. Michael Pilato <cm...@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand