[GitHub] [hudi] nsivabalan commented on issue #4585: Target Schema cannot be set in MultiTableDeltaStreamer

[GitBox <gi...@apache.org>]

nsivabalan commented on issue #4585:
URL: https://github.com/apache/hudi/issues/4585#issuecomment-1013346554


   Hey @chrischnweiss : I inspected the code and I feel we could configure per table schema providers. 
   ```
    String schemaRegistryBaseUrl = typedProperties.getString(Constants.SCHEMA_REGISTRY_BASE_URL_PROP);
         String schemaRegistrySuffix = typedProperties.getString(Constants.SCHEMA_REGISTRY_URL_SUFFIX_PROP, null);
         String sourceSchemaRegistrySuffix;
         String targetSchemaRegistrySuffix;
         if (StringUtils.isNullOrEmpty(schemaRegistrySuffix)) {
           sourceSchemaRegistrySuffix = typedProperties.getString(Constants.SCHEMA_REGISTRY_SOURCE_URL_SUFFIX);
           targetSchemaRegistrySuffix = typedProperties.getString(Constants.SCHEMA_REGISTRY_TARGET_URL_SUFFIX);
         } else {
           targetSchemaRegistrySuffix = schemaRegistrySuffix;
           sourceSchemaRegistrySuffix = schemaRegistrySuffix;
         }
         typedProperties.setProperty(Constants.SOURCE_SCHEMA_REGISTRY_URL_PROP, schemaRegistryBaseUrl + typedProperties.getString(Constants.KAFKA_TOPIC_PROP) + sourceSchemaRegistrySuffix);
         typedProperties.setProperty(Constants.TARGET_SCHEMA_REGISTRY_URL_PROP, schemaRegistryBaseUrl + typedProperties.getString(Constants.KAFKA_TOPIC_PROP) + targetSchemaRegistrySuffix);
       }
   ```
   
   If you set `hoodie.deltastreamer.schemaprovider.registry.urlSuffix`, and then you can set appropriate values for `hoodie.deltastreamer.schemaprovider.registry.sourceUrlSuffix` and `hoodie.deltastreamer.schemaprovider.registry.targetUrlSuffix`. 
   but base url and kafka topic will have to same for both source and target schema. 
   
   Does above proposal work for you? I understand, it may not be as easy as setting register.url and registery.targetUrl directly at per table level. But looking if we can achieve w/ existing code. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org