You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tmgodinho (via GitHub)" <gi...@apache.org> on 2025/08/20 10:32:02 UTC
[PR] IGNITE-26221 Fix org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
tmgodinho opened a new pull request, #6456:
URL: https://github.com/apache/ignite-3/pull/6456
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26221 Relax assertions in org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn merged PR #6456:
URL: https://github.com/apache/ignite-3/pull/6456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26221 Relax assertions in org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
Posted by "tmgodinho (via GitHub)" <gi...@apache.org>.
tmgodinho commented on code in PR #6456:
URL: https://github.com/apache/ignite-3/pull/6456#discussion_r2334426263
##########
modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java:
##########
@@ -158,10 +159,11 @@ public void testHandshakesFailedTimeout() throws InterruptedException {
);
client = clientBuilder()
.connectTimeout(100)
+ .asyncContinuationExecutor(Executors.newFixedThreadPool(3))
Review Comment:
I've reverted that change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26221 Relax assertions in org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
Posted by "tmgodinho (via GitHub)" <gi...@apache.org>.
tmgodinho commented on code in PR #6456:
URL: https://github.com/apache/ignite-3/pull/6456#discussion_r2321495323
##########
modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java:
##########
@@ -158,10 +159,11 @@ public void testHandshakesFailedTimeout() throws InterruptedException {
);
client = clientBuilder()
.connectTimeout(100)
+ .asyncContinuationExecutor(Executors.newFixedThreadPool(3))
Review Comment:
I @ptupitsyn sorry I missed your comment again.
Since I could not determine or reproduce the actual cause of the timeouts, I decided to isolate the tests better.
I think the test previously was using the fork-join pool, which is shared by everything in the suite, so it's queue might get clogged by another process and contribute to the errors.
I can revert this if you do not think this is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26221 Relax assertions in org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #6456:
URL: https://github.com/apache/ignite-3/pull/6456#discussion_r2321533969
##########
modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java:
##########
@@ -158,10 +159,11 @@ public void testHandshakesFailedTimeout() throws InterruptedException {
);
client = clientBuilder()
.connectTimeout(100)
+ .asyncContinuationExecutor(Executors.newFixedThreadPool(3))
Review Comment:
I'm 99% sure there is no common pool starvation in those tests :)
Let's revert this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-26221 Relax assertions in org.apache.ignite.client.ClientMetricsTest.testHandshakesFailedTimeout [ignite-3]
Posted by "ptupitsyn (via GitHub)" <gi...@apache.org>.
ptupitsyn commented on code in PR #6456:
URL: https://github.com/apache/ignite-3/pull/6456#discussion_r2315651674
##########
modules/client/src/test/java/org/apache/ignite/client/ClientMetricsTest.java:
##########
@@ -158,10 +159,11 @@ public void testHandshakesFailedTimeout() throws InterruptedException {
);
client = clientBuilder()
.connectTimeout(100)
+ .asyncContinuationExecutor(Executors.newFixedThreadPool(3))
Review Comment:
How does this help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org