You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/02 05:45:41 UTC

[jira] [Commented] (THRIFT-3288) c_glib: Build unit tests with all warnings enabled, no warnings generated

    [ https://issues.apache.org/jira/browse/THRIFT-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952533#comment-15952533 ] 

ASF GitHub Bot commented on THRIFT-3288:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/577
  
    @jfarrell this is marked closed fixed in Jira.  This PR can be closed.


> c_glib: Build unit tests with all warnings enabled, no warnings generated
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-3288
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3288
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C glib - Library
>    Affects Versions: 0.9.3
>         Environment: Cloud9 (Ubuntu 14.04.2 LTS; gcc 4.8.2)
>            Reporter: Simon South
>            Assignee: Simon South
>            Priority: Minor
>              Labels: c_glib, unit-test
>             Fix For: 0.9.3
>
>
> For correctness and to help with tracking down bugs, the C (GLib) unit tests (in {{lib/c_glib/test}}) should build with the same compiler-warning options enabled for the C++ library's tests ({{-Wall -Wextra -pedantic}}) and without any warnings generated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)