[jira] [Commented] (AIRFLOW-3259) Internal Server Error when creating charts because of sort function

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667260#comment-16667260 ] 

ASF GitHub Bot commented on AIRFLOW-3259:
-----------------------------------------

zackmeso opened a new pull request #4114: AIRFLOW-3259] Fix internal server error when displaying charts
URL: https://github.com/apache/incubator-airflow/pull/4114
 
 
   This is caused by the fact that the function 'sort' is no longer a part of Dataframe in pandas and is still used in the code base. It has ever since been replaced by 'sort_values'. Replacing the function gets the chart display back to its normal behaviour.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3259/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   **Problem**
   When you try to create a chart and display metrics you get an internal server error.
   
   **Cause**
   A dependency issue: the function "sort" was deprecated and is no longer a part of pandas Dataframe and thus it creates a problem when creating charts in airflow.
   
   **Solution**
   The sort function needs to replaced by sort_values instead (See code below)
   `# Replace this `
   `df = df.sort(df.columns[0]) `
   `# By this `
   `df = df.sort_values(by=df.columns[0])`
   In views.py
   
   **Result**
   The data is loaded and the chart displayed   
   
   ### Tests
   
   - [x] My PR does not need testing for this extremely good reason:
   My code doesn't change the behavior of the code, but rather modifies a no longer existing function (in pandas) with its new substitute.
   
   ### Commits
   
   - [x] My commit all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Internal Server Error when creating charts because of sort function
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-3259
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3259
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 1.10.0
>         Environment: I reproduces this error in two environments
> CentOs 7 with python2.7
> MacOs High Sierra with python 3.6
>            Reporter: Zakaria EL Mesaoudi
>            Assignee: Zakaria EL Mesaoudi
>            Priority: Blocker
>              Labels: pull-request-available
>         Attachments: Screen Shot 2018-10-25 at 8.01.09 PM.png, Screen Shot 2018-10-25 at 8.01.52 PM.png, Screen Shot 2018-10-25 at 8.02.50 PM.png, Screen Shot 2018-10-25 at 8.16.53 PM.png
>
>
> h2. {color:#205081}*Problem*{color}
> h3. When you try to create a chart and display metrics you get an internal server error (See picture below).
> h3. !Screen Shot 2018-10-25 at 8.01.09 PM.png|width=605,height=222!
> h2. {color:#205081}*Cause*{color}
> h3. When you click on the url rendering the internal server error you get this: (See picture below)
> h2. !Screen Shot 2018-10-25 at 8.01.52 PM.png|width=605,height=535!
> h3. A dependency issue: the function "sort" was deprecated and is no longer a part of pandas Dataframe and thus it creates a problem when creating charts in airflow.
> h2. {color:#205081}*Solution*{color}
> h3. The sort function needs to replaced by sort_values instead (See code below)
>  
>  
> {code:java}
> # Replace this 
> df = df.sort(df.columns[0]) 
> # By this 
> df = df.sort_values(by=df.columns[0])
> {code}
> In views.py (See picture below)
> !Screen Shot 2018-10-25 at 8.02.50 PM.png|width=603,height=593!
> h2. {color:#205081}*Result*{color}
> The data is loaded and the chart displayed  :D 
> !Screen Shot 2018-10-25 at 8.16.53 PM.png|width=607,height=245!
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)