[GitHub] [skywalking] toffentoffen commented on a diff in pull request #11120: Do not print sensitive properties' values in logs

["toffentoffen (via GitHub)" <gi...@apache.org>]

toffentoffen commented on code in PR #11120:
URL: https://github.com/apache/skywalking/pull/11120#discussion_r1269335757


##########
oap-server/server-starter/src/main/java/org/apache/skywalking/oap/server/starter/config/ApplicationConfigLoader.java:
##########
@@ -40,6 +43,15 @@
  */
 @Slf4j
 public class ApplicationConfigLoader implements ConfigLoader<ApplicationConfiguration> {
+    static final Set<String> SENSITIVE_PROPERTY_NAMES =
+        ImmutableSet.<String>builder()
+                    .add("password")
+                    .add("authentication")
+                    .add("accessKey")
+                    .add("secretKey")

Review Comment:
   NIT: Check against https://skywalking.apache.org/docs/main/next/en/setup/backend/configuration-vocabulary/ and I think 1 is missing.
   ```suggestion
                       .add("secretKey")
                       .add("firehoseAccessKey")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org