You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/10 22:52:22 UTC

[GitHub] graceguo-supercat closed pull request #4383: Typo fix: dashbaord -> dashboard.

graceguo-supercat closed pull request #4383: Typo fix: dashbaord -> dashboard.
URL: https://github.com/apache/incubator-superset/pull/4383
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/dashboard/components/Controls.jsx b/superset/assets/javascripts/dashboard/components/Controls.jsx
index 1d66a51d10..00cb6d56dc 100644
--- a/superset/assets/javascripts/dashboard/components/Controls.jsx
+++ b/superset/assets/javascripts/dashboard/components/Controls.jsx
@@ -168,7 +168,7 @@ class Controls extends React.PureComponent {
           {editMode &&
             <ActionMenuItem
               text={t('Email')}
-              tooltip={t('Email a link to this dashbaord')}
+              tooltip={t('Email a link to this dashboard')}
               onClick={() => { window.location = emailLink; }}
               faIcon="envelope"
             />
@@ -181,7 +181,7 @@ class Controls extends React.PureComponent {
               triggerNode={
                 <MenuItemContent
                   text={t('Add Slices')}
-                  tooltip={t('Add some slices to this dashbaord')}
+                  tooltip={t('Add some slices to this dashboard')}
                   faIcon="plus"
                 />
               }
diff --git a/superset/assets/javascripts/dashboard/components/GridLayout.jsx b/superset/assets/javascripts/dashboard/components/GridLayout.jsx
index b5dd49a4fc..68de7686ce 100644
--- a/superset/assets/javascripts/dashboard/components/GridLayout.jsx
+++ b/superset/assets/javascripts/dashboard/components/GridLayout.jsx
@@ -102,7 +102,7 @@ class GridLayout extends React.Component {
       return;
     }
 
-    // remove slice dashbaord and charts
+    // remove slice dashboard and charts
     this.props.removeSlice(slice);
     this.props.removeChart(this.props.charts['slice_' + slice.slice_id].chartKey);
     this.props.onChange();


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services