You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/01/12 21:06:54 UTC
[jira] Created: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Pass build.dir.hive and other properties to subant
--------------------------------------------------
Key: HIVE-1046
URL: https://issues.apache.org/jira/browse/HIVE-1046
Project: Hadoop Hive
Issue Type: Bug
Affects Versions: 0.4.1, 0.5.0, 0.6.0
Reporter: Zheng Shao
Assignee: Zheng Shao
Currently we are not passing properties like "build.dir.hive" etc to subant.
We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801231#action_12801231 ]
Namit Jain commented on HIVE-1046:
----------------------------------
Committed in 0.5 also
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1046.1.patch, HIVE-1046.2.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800088#action_12800088 ]
Namit Jain commented on HIVE-1046:
----------------------------------
TestMTQueries is failing - can you take a look ?
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800069#action_12800069 ]
Namit Jain commented on HIVE-1046:
----------------------------------
+1
will commit if the tests pass
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Paul Yang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800481#action_12800481 ]
Paul Yang commented on HIVE-1046:
---------------------------------
The reason why this error is getting triggered is because previously diff would ignore lines that contained /tmp/. Now that we are using a user specified directory, that line doesn't get ignored anymore.
Normally, lines that begin with 'file:/' get ignored anyway, but in groupby1.q, we do:
{code}
set fs.default.name=invalidscheme:///;
EXPLAIN
FROM src INSERT OVERWRITE TABLE dest_g1 SELECT src.key, sum(substr(src.value,5)) GROUP BY src.key;
{code}
The issue with this test is that the log file will contain invalidscheme:/<user's directory> and he user's directory will always trip up the test.
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1046:
-----------------------------
Attachment: HIVE-1046.2.patch
It turns out that I have to pass the parameters down to the jvm that is spawned from MapRedTask.
Note that the variables in hive-site.xml are expanded by referencing to Java System Properties (the properties passed by "-D" to jvm, or by "sysproperty" directive in build-comon.xml junit test).
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch, HIVE-1046.2.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-1046:
---------------------------------
Fix Version/s: 0.5.0
(was: 0.6.0)
Affects Version/s: (was: 0.5.0)
(was: 0.6.0)
Component/s: Build Infrastructure
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Build Infrastructure
> Affects Versions: 0.4.1
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.5.0
>
> Attachments: HIVE-1046.1.patch, HIVE-1046.2.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Ning Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800062#action_12800062 ]
Ning Zhang commented on HIVE-1046:
----------------------------------
+1 changes looks good.
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800527#action_12800527 ]
Zheng Shao commented on HIVE-1046:
----------------------------------
Thanks for the analysis Paul!
I will modify the diff command to ignore the lines starting with "invalidscheme".
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain resolved HIVE-1046.
------------------------------
Resolution: Fixed
Fix Version/s: 0.6.0
Hadoop Flags: [Reviewed]
Committed. Thanks Zheng
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1046.1.patch, HIVE-1046.2.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1046) Pass build.dir.hive and other
properties to subant
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1046:
-----------------------------
Attachment: HIVE-1046.1.patch
Modified all places to use user-specified directory.
This will do the job:
{code}
ant test -Dbuild.dir.hive=abc
{code}
Note that the derby directory is still in build. There is no easy way to change that because derby does not do variable substitution in conf.
> Pass build.dir.hive and other properties to subant
> --------------------------------------------------
>
> Key: HIVE-1046
> URL: https://issues.apache.org/jira/browse/HIVE-1046
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.4.1, 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Attachments: HIVE-1046.1.patch
>
>
> Currently we are not passing properties like "build.dir.hive" etc to subant.
> We should do that, otherwise setting "build.dir.hive" is not useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.