You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/08 18:20:51 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #16999: [fix][flaky-test]TxnLogBufferedWriterTest.testMainProcess callback mismatch
poorbarcode opened a new pull request, #16999:
URL: https://github.com/apache/pulsar/pull/16999
Fixes #16989
Master Issue: #16989
### Motivation
We mocked a BK error, but if an exception occurs, the failure callback will be executed earlier. So the results of the callbacks will be out of order, resulting in a mismatch with the expected value.
### Modifications
If we mocked BK errors, sort the callback results.
### Documentation
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16999: [fix][flaky-test]TxnLogBufferedWriterTest.testMainProcess
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16999:
URL: https://github.com/apache/pulsar/pull/16999#issuecomment-1210241023
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16999: [fix][flaky-test]TxnLogBufferedWriterTest.testMainProcess
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16999:
URL: https://github.com/apache/pulsar/pull/16999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org