[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #208: Add sbt-header to code style checks

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #208:
URL: https://github.com/apache/incubator-pekko-connectors/pull/208#discussion_r1294236631


##########
build.sbt:
##########
@@ -129,8 +129,8 @@ lazy val `pekko-connectors` = project
     crossScalaVersions := List() // workaround for https://github.com/sbt/sbt/issues/3465
   )
 
-addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll")
-addCommandAlias("checkCodeStyle", ";scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")
+addCommandAlias("applyCodeStyle", ";scalafmtAll; scalafmtSbt; javafmtAll; +headerCheckAll")
+addCommandAlias("checkCodeStyle", "+headerCreateAll; ;scalafmtCheckAll; scalafmtSbtCheck; javafmtCheckAll")

Review Comment:
   I guess we should use a common name, I prefer checkCodeStyle. If you agree should I just make a PR in pekko to change it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org