You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prabodh1194 (via GitHub)" <gi...@apache.org> on 2024/09/12 04:57:23 UTC

[PR] obtain fixture artifact path programmatically [hudi-rs]

prabodh1194 opened a new pull request, #137:
URL: https://github.com/apache/hudi-rs/pull/137

   ## Description
   
   I am setting up my dev environment in RustRover IDE and wanted to run the pytest from the IDE's command runner. However, the default setup was giving me some issue related to the `.zip` table artifact. To work around this, I have colocated a python script with the artifact so that I can deterministically get the correct path of the corresponding zip file. 
   
   ## How are the changes test-covered
   
   - [ ] N/A
   - [ ] Automated tests (unit and/or integration tests)
   - [ ] Manual tests
     - [ ] Details are described below
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2509191306

   > @prabodh1194 I created #141 as an extended work for this. If you're interested, feel free to pick it up.
   
   We will cover this PR's intent in #141 so we can close this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "prabodh1194 (via GitHub)" <gi...@apache.org>.
prabodh1194 commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2347898337

   @KnightChess should I go ahead & add a pre-commit hook for `ruff format` ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] obtain fixture artifact path programmatically [hudi-rs]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2345295892

   ## [Codecov](https://app.codecov.io/gh/apache/hudi-rs/pull/137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 87.77%. Comparing base [(`01ef2fc`)](https://app.codecov.io/gh/apache/hudi-rs/commit/01ef2fc196b77a4a55a8d2f6b6f74fd011938968?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2d72224`)](https://app.codecov.io/gh/apache/hudi-rs/commit/2d72224e1f684a6ac06a0bb6825a1fe3585c1527?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@           Coverage Diff           @@
   ##             main     #137   +/-   ##
   =======================================
     Coverage   87.77%   87.77%           
   =======================================
     Files          14       14           
     Lines         728      728           
   =======================================
     Hits          639      639           
     Misses         89       89           
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/hudi-rs/pull/137?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on code in PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#discussion_r1759962241


##########
python/tests/conftest.py:
##########
@@ -17,12 +17,15 @@
 
 import os
 import zipfile
-from pathlib import Path
+from pathlib import Path, PosixPath
 
 import pytest
+from _pytest.fixtures import SubRequest
 
+from tests.table.table_path import get_table_path
 
-def _extract_testing_table(zip_file_path, target_path) -> str:
+
+def _extract_testing_table(zip_file_path: Path, target_path: PosixPath) -> str:

Review Comment:
   PosixPath restricted this from running on windows? we'll need to support test and build on windows too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2351379867

   @prabodh1194 I created https://github.com/apache/hudi-rs/issues/141 as an extended work for this. If you're interested, feel free to pick it up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "prabodh1194 (via GitHub)" <gi...@apache.org>.
prabodh1194 commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2348111365

   fair enough. thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "prabodh1194 (via GitHub)" <gi...@apache.org>.
prabodh1194 commented on PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#issuecomment-2366865110

   thanks. lemme try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "prabodh1194 (via GitHub)" <gi...@apache.org>.
prabodh1194 commented on code in PR #137:
URL: https://github.com/apache/hudi-rs/pull/137#discussion_r1759999509


##########
python/tests/conftest.py:
##########
@@ -17,12 +17,15 @@
 
 import os
 import zipfile
-from pathlib import Path
+from pathlib import Path, PosixPath
 
 import pytest
+from _pytest.fixtures import SubRequest
 
+from tests.table.table_path import get_table_path
 
-def _extract_testing_table(zip_file_path, target_path) -> str:
+
+def _extract_testing_table(zip_file_path: Path, target_path: PosixPath) -> str:

Review Comment:
   Oh. Got it. Lemme figure out how to test this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: obtain fixture artifact path programmatically [hudi-rs]

Posted by "xushiyan (via GitHub)" <gi...@apache.org>.
xushiyan closed pull request #137: test: obtain fixture artifact path programmatically
URL: https://github.com/apache/hudi-rs/pull/137


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org