[GitHub] [spark] planga82 commented on a diff in pull request #38871: [SPARK-41344][SQL] Make error clearer when table not found in SupportsCatalogOptions catalog

[GitBox <gi...@apache.org>]

planga82 commented on code in PR #38871:
URL: https://github.com/apache/spark/pull/38871#discussion_r1042297374


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Utils.scala:
##########
@@ -134,7 +134,11 @@ private[sql] object DataSourceV2Utils extends Logging {
           None
         }
         val timeTravel = TimeTravelSpec.create(timeTravelTimestamp, timeTravelVersion, conf)
-        (CatalogV2Util.loadTable(catalog, ident, timeTravel).get, Some(catalog), Some(ident))

Review Comment:
   Probably it's better to have a new method in CatalogV2Util that do the same as loadTable but without catch exceptions and return Table instead of Option[Table]



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org