[GitHub] [pulsar-client-cpp] merlimat commented on a diff in pull request #11: Fixed RPM / Deb / APK packages and enabled CI build

[GitBox <gi...@apache.org>]

merlimat commented on code in PR #11:
URL: https://github.com/apache/pulsar-client-cpp/pull/11#discussion_r984694878


##########
pkg/deb/docker-build-deb.sh:
##########
@@ -20,15 +20,10 @@
 
 set -ex
 
-ROOT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )"/../../.. &> /dev/null && pwd )"
-IMAGE_NAME=apachepulsar/pulsar-build:debian-9-2.11
+ROOT_DIR=$(git rev-parse --show-toplevel)
 
-if [[ -z $BUILD_IMAGE ]]; then
-    # pull the image from DockerHub by default
-    docker pull $IMAGE_NAME
-else
-    docker build --platform linux/amd64 -t $IMAGE_NAME $ROOT_DIR/pulsar-client-cpp/pkg/deb
-fi
+IMAGE_NAME=apachepulsar/pulsar-build:debian-9-2.11-x86_64

Review Comment:
   Ideally, we should use unique image tags. 
   
   At this point the process would be to update the Dockerfile, build the image locally and push it to Dockerhub with the same tag. All the builds after that will sync and fetch the updated image.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org