[GitHub] [tvm] janetsc commented on a diff in pull request #13145: [Hexagon] refactor HexagonBufferManager class

[GitBox <gi...@apache.org>]

janetsc commented on code in PR #13145:
URL: https://github.com/apache/tvm/pull/13145#discussion_r999982587


##########
src/runtime/hexagon/hexagon_device_api.cc:
##########
@@ -154,8 +154,6 @@ void HexagonDeviceAPI::FreeWorkspace(Device dev, void* data) {
   CHECK(runtime_hexbuffs) << "Attempted to free Hexagon workspace with "
                           << "HexagonDeviceAPI::FreeWorkspace outside of a session.  "
                           << "Please call HexagonDeviceAPI::AcquireResources";
-  CHECK(runtime_hexbuffs->count(data) != 0)

Review Comment:
   It is ok to remove count, but should be replaced with FindHexagonBuffer.  We want to make sure that the backing data buffer for this workspace is still actively allocated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org