You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:44:47 UTC
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3146: [GOBBLIN-1309] Abort when registration is happening against a view
codecov-io commented on pull request #3146:
URL: https://github.com/apache/incubator-gobblin/pull/3146#issuecomment-720784586
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=h1) Report
> Merging [#3146](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/58fbf67b6065a373ab1e8afd427b75612ee65370?el=desc) will **increase** coverage by `4.28%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3146 +/- ##
============================================
+ Coverage 41.75% 46.03% +4.28%
- Complexity 8741 9588 +847
============================================
Files 1986 1986
Lines 75819 75824 +5
Branches 8446 8447 +1
============================================
+ Hits 31656 34905 +3249
+ Misses 41145 37639 -3506
- Partials 3018 3280 +262
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/hive/metastore/HiveMetaStoreBasedRegister.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL21ldGFzdG9yZS9IaXZlTWV0YVN0b3JlQmFzZWRSZWdpc3Rlci5qYXZh) | `10.27% <0.00%> (-0.15%)` | `5.00 <0.00> (ø)` | |
| [.../limiter/RedirectAwareRestClientRequestSender.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9SZWRpcmVjdEF3YXJlUmVzdENsaWVudFJlcXVlc3RTZW5kZXIuamF2YQ==) | `84.88% <0.00%> (-2.33%)` | `17.00% <0.00%> (-1.00%)` | |
| [...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh) | `67.04% <0.00%> (+0.22%)` | `83.00% <0.00%> (+1.00%)` | |
| [.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==) | `50.00% <0.00%> (+0.51%)` | `29.00% <0.00%> (ø%)` | |
| [...ache/gobblin/cluster/GobblinHelixMultiManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4TXVsdGlNYW5hZ2VyLmphdmE=) | `53.64% <0.00%> (+0.52%)` | `17.00% <0.00%> (+1.00%)` | |
| [...main/java/org/apache/gobblin/util/ConfigUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQ29uZmlnVXRpbHMuamF2YQ==) | `58.86% <0.00%> (+0.63%)` | `41.00% <0.00%> (+1.00%)` | |
| [...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=) | `75.72% <0.00%> (+0.82%)` | `71.00% <0.00%> (ø%)` | |
| [.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=) | `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
| [...e/gobblin/util/filesystem/FileSystemDecorator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtRGVjb3JhdG9yLmphdmE=) | `13.07% <0.00%> (+1.96%)` | `13.00% <0.00%> (+2.00%)` | |
| [...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh) | `61.55% <0.00%> (+2.07%)` | `38.00% <0.00%> (+2.00%)` | |
| ... and [151 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3146/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=footer). Last update [58fbf67...68e897e](https://codecov.io/gh/apache/incubator-gobblin/pull/3146?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org