Re: [PR] #9073 Junit 4 tests switched to JUnit 5 [iceberg]

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #9793:
URL: https://github.com/apache/iceberg/pull/9793#discussion_r1547543252


##########
data/src/test/java/org/apache/iceberg/data/DataTestHelpers.java:
##########
@@ -84,16 +86,16 @@ private static void assertEquals(Type type, Object expected, Object actual) {
       case UUID:
       case BINARY:
       case DECIMAL:
-        Assert.assertEquals(
-            "Primitive value should be equal to expected for type " + type, expected, actual);
+        org.junit.jupiter.api.Assertions.assertEquals(
+            expected, actual, "Primitive value should be equal to expected for type " + type);
         break;
       case FIXED:
         Assertions.assertThat(expected)
             .as("Expected should be a byte[]")
             .isInstanceOf(byte[].class);
         Assertions.assertThat(expected).as("Actual should be a byte[]").isInstanceOf(byte[].class);
-        Assert.assertArrayEquals(
-            "Array contents should be equal", (byte[]) expected, (byte[]) actual);
+        org.junit.jupiter.api.Assertions.assertArrayEquals(

Review Comment:
   this should use AssertJ's `assertThat()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org