You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/17 08:15:36 UTC

[GitHub] zeppelin pull request #2256: [ZEPPELIN-2315] (bug) new note.json is overwrit...

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/2256

[ZEPPELIN-2315] (bug) new note.json is overwritten by old note.json (master, branch-0.7)

### What is this PR for?

- `note.json` is converted every time
- as a result, changes in `note.json` is overwritten by old `note.json`

Occurs in **0.8.0-SNAPSHOT** and **branch-0.7**

### What type of PR is it?
[Bug Fix]

### Todos

NONE

### What is the Jira issue?

[ZEPPELIN-2315](https://issues.apache.org/jira/browse/ZEPPELIN-2315)

### How should this be tested?

1. create a note in 0.6.0 which including graph
2. migrate it to 0.7.0+ (just copy dir)
3. open in Zeppelin
4. click other graph type rather than table (e.g `scatter chart`)
5. restart
7. should see the last change (graph) is persisted

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2315/should-convert-old-notebook-only-once

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2256

----

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2256: [ZEPPELIN-2315] (bug) new note.json is overwritten by ...

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2256
  
    Ok make sense. LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2256: [ZEPPELIN-2315] (bug) new note.json is overwritten by ...

Posted by 1ambda <gi...@git.apache.org>.

Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2256
  
    Old version zeppelins will not render converted note.json. On the other hand, if we keep 'result', they can render last version of old format. Is it ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---