You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "DevanshSingh-Ksolves (via GitHub)" <gi...@apache.org> on 2026/10/15 14:06:23 UTC

Re: [PR] [SPARK-60216][SQL] Assign a name to the error condition LEGACY_ERROR_TEMP_1002 [spark]

DevanshSingh-Ksolves commented on code in PR #59462:
URL: https://github.com/apache/spark/pull/59462#discussion_r4283997528


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoderSuite.scala:
##########
@@ -1021,4 +1027,25 @@ class ExpressionEncoderSuite extends CodegenInterpretedPlanTest with AnalysisTes
       }
     }
   }
+
+  test("SPARK-60216: inner class encoder missing outer scope") {

Review Comment:
   @HyukjinKwon Thanks for the review! I have moved the test and the OuterClassForTest fixture together into the inner-class encoder section as requested, keeping it as a member class of the suite.
   
   Also, i have re-titled the PR name. Thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org