You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/12 19:19:46 UTC

[GitHub] [spark] johnhany97 commented on a change in pull request #26867: [SPARK-30236][SQL][DOCS][2.4] Clarify date and time patterns supported by date_format

johnhany97 commented on a change in pull request #26867: [SPARK-30236][SQL][DOCS][2.4] Clarify date and time patterns supported by date_format
URL: https://github.com/apache/spark/pull/26867#discussion_r357324807
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
 ##########
 @@ -541,7 +541,7 @@ case class WeekOfYear(child: Expression) extends UnaryExpression with ImplicitCa
 
 // scalastyle:off line.size.limit
 @ExpressionDescription(
-  usage = "_FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`.",
+  usage = "_FUNC_(timestamp, fmt) - Converts `timestamp` to a value of string in the format specified by the date format `fmt`. See `java.text.SimpleDateFormat` for valid date and time format patterns.",
 
 Review comment:
   Sure thing
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org