You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/02/24 11:28:48 UTC
[GitHub] [tinkerpop] egetman opened a new pull request #1397: Fixed NPE during the ResponseMessageDeserializer#createObject
egetman opened a new pull request #1397:
URL: https://github.com/apache/tinkerpop/pull/1397
Supersedes #1394
@spmallette I'm not sure about the other serializers, but I've checked the:
```
AbstractGryoMessageSerializerV1d0 (& GryoMessageSerializerV1d0)
AbstractGryoMessageSerializerV3d0 (& GryoMessageSerializerV3d0)
GraphBinaryMessageSerializerV1
```
It's ok with the null message. If you mean some other serializers, please let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1397: Fixed NPE during the ResponseMessageDeserializer#createObject
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1397:
URL: https://github.com/apache/tinkerpop/pull/1397#issuecomment-785868599
I re-ran the job and it passed. I don't think there's anything to worry about, especially as a result of your change. Travis is just weird sometimes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] egetman commented on pull request #1397: Fixed NPE during the ResponseMessageDeserializer#createObject
Posted by GitBox <gi...@apache.org>.
egetman commented on pull request #1397:
URL: https://github.com/apache/tinkerpop/pull/1397#issuecomment-785845628
Hi, @spmallette.
Is it a flaky test in the .Net module, or I accidentally broke something?
Common tests via `mvn clean install` for .Net module passed successfully:
```
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [ 8.378 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [ 0.206 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [ 0.130 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
```
Integration tests failed with OOM on my laptop with `docker/build.sh -i` cmd. Is there another way to trigger only a subset of it tests locally?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1397: Fixed NPE during the ResponseMessageDeserializer#createObject
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1397:
URL: https://github.com/apache/tinkerpop/pull/1397
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1397: Fixed NPE during the ResponseMessageDeserializer#createObject
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1397:
URL: https://github.com/apache/tinkerpop/pull/1397#issuecomment-785044079
If you checked and you don't see anything in those places to change then I'd say there's nothing else to look at. Thanks for making the other changes I'd asked for.
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org