You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/23 12:57:49 UTC
[GitHub] [servicecomb-java-chassis] GuoYL123 opened a new pull request
#1657: change kie label env to environment
GuoYL123 opened a new pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull
request #1657: change kie label env to environment
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657#discussion_r396862336
##########
File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
##########
@@ -65,7 +65,7 @@ public static String encrypt(String dataStr) {
//todo:how to deal env
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull
request #1657: change kie label env to environment
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657#discussion_r396836836
##########
File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
##########
@@ -65,7 +65,7 @@ public static String encrypt(String dataStr) {
//todo:how to deal env
if (labelsMap.containsKey("app") && labelsMap.get("app")
.equals(KieConfig.INSTANCE.getAppName())
- && labelsMap.containsKey("env") && labelsMap.get("env")
+ && labelsMap.containsKey("environment") && labelsMap.get("environment")
Review comment:
Too many literals in a function, better to define constants for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1657:
[SCB-1823] change kie label env to environment
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1657: [SCB-1823] change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull
request #1657: change kie label env to environment
Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657#discussion_r396862300
##########
File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
##########
@@ -65,7 +65,7 @@ public static String encrypt(String dataStr) {
//todo:how to deal env
if (labelsMap.containsKey("app") && labelsMap.get("app")
.equals(KieConfig.INSTANCE.getAppName())
- && labelsMap.containsKey("env") && labelsMap.get("env")
+ && labelsMap.containsKey("environment") && labelsMap.get("environment")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull
request #1657: change kie label env to environment
Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1657: change kie label env to environment
URL: https://github.com/apache/servicecomb-java-chassis/pull/1657#discussion_r396836949
##########
File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
##########
@@ -65,7 +65,7 @@ public static String encrypt(String dataStr) {
//todo:how to deal env
Review comment:
Can this todo removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services