You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/02/21 11:33:52 UTC
Review Request 70034: Consistently used `override` in tests'
`BlockingAuthorizer`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70034/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Greg Mann.
Repository: mesos
Description
-------
Consistently used `override` in tests' `BlockingAuthorizer`.
Diffs
-----
src/tests/master_load_tests.cpp 4e9c8e89d50a7a93f3e25b7120f4d2ec4e44a0c8
Diff: https://reviews.apache.org/r/70034/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 70034: Consistently used `override` in tests'
`BlockingAuthorizer`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70034/#review213027
-----------------------------------------------------------
Ship it!
I was about to propose adding this to our style guide AS WELL, but then I saw that it's already in there!
- Benno Evers
On Feb. 21, 2019, 11:33 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70034/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2019, 11:33 a.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Consistently used `override` in tests' `BlockingAuthorizer`.
>
>
> Diffs
> -----
>
> src/tests/master_load_tests.cpp 4e9c8e89d50a7a93f3e25b7120f4d2ec4e44a0c8
>
>
> Diff: https://reviews.apache.org/r/70034/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70034: Consistently used `override` in tests'
`BlockingAuthorizer`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70034/#review213026
-----------------------------------------------------------
PASS: Mesos patch 70034 was successfully built and tested.
Reviews applied: `['70034']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2917/mesos-review-70034
- Mesos Reviewbot Windows
On Feb. 21, 2019, 3:33 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70034/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2019, 3:33 a.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Consistently used `override` in tests' `BlockingAuthorizer`.
>
>
> Diffs
> -----
>
> src/tests/master_load_tests.cpp 4e9c8e89d50a7a93f3e25b7120f4d2ec4e44a0c8
>
>
> Diff: https://reviews.apache.org/r/70034/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>