You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/10 21:07:03 UTC

[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #1747: sched: Rename note_add to sched_note_add

ghn-certi commented on a change in pull request #1747:
URL: https://github.com/apache/incubator-nuttx/pull/1747#discussion_r486633101



##########
File path: sched/Kconfig
##########
@@ -894,22 +894,11 @@ config SCHED_INSTRUMENTATION
 	---help---
 		Enables instrumentation in scheduler to monitor system performance.
 		If enabled, then the board-specific logic must provide the following
-		functions (see include/sched.h):
+		functions (see include/sched_note.h):
 
-			void sched_note_start(FAR struct tcb_s *tcb);
-			void sched_note_stop(FAR struct tcb_s *tcb);
-			void sched_note_suspend(FAR struct tcb_s *tcb);
-			void sched_note_resume(FAR struct tcb_s *tcb);
+			void sched_note_add(FAR const void *note, size_t notelen);
 
-		If CONFIG_SMP is enabled, then these additional interfaces are
-		expected:
-
-			void sched_note_cpu_pause(FAR struct tcb_s *tcb, int cpu);
-			void sched_note_cpu_paused(FAR struct tcb_s *tcb);
-			void sched_note_cpu_resume(FAR struct tcb_s *tcb, int cpu);
-			void sched_note_cpu_resumed(FAR struct tcb_s *tcb);
-
-		NOTE: These are internal OS interfaces and are called at at very
+		NOTE: This is an internal OS interfaces and are called at at very

Review comment:
       ```suggestion
   		NOTE: This is an internal OS interface and is called at very
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org