[mesos] branch master updated: Revert "Fixed read of uninitialized variables detected with UBSAN."

[as...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

asekretenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new 62d44d1  Revert "Fixed read of uninitialized variables detected with UBSAN."
62d44d1 is described below

commit 62d44d167220caff5fc0c42270671fb99a6a9fc8
Author: Andrei Sekretenko <as...@gmailcom>
AuthorDate: Sun May 16 09:53:25 2021 +0200

    Revert "Fixed read of uninitialized variables detected with UBSAN."
    
    This reverts commit add9f1de771693884548095703ed2bd4bc6cfc16.
    
    As it turns out, fixing this UB this way exposes some other issue
    in containerizer tests - for example,
    `MesosContainerizerTest.StatusWithContainerID` - which results
    in failures to wait for cgroup destruction on some platforms
    in the affected tests. Temporarily reverting this pending further
    investigation. See https://github.com/apache/mesos/pull/385
---
 src/tests/cluster.hpp | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/tests/cluster.hpp b/src/tests/cluster.hpp
index eae6bcf..b36b94f 100644
--- a/src/tests/cluster.hpp
+++ b/src/tests/cluster.hpp
@@ -106,8 +106,7 @@ public:
   void setAuthorizationCallbacks(Authorizer* authorizer);
 
 private:
-  Master() : files(master::READONLY_HTTP_AUTHENTICATION_REALM),
-             authorizationCallbacksSet(false) {}
+  Master() : files(master::READONLY_HTTP_AUTHENTICATION_REALM) {};
 
   // Not copyable, not assignable.
   Master(const Master&) = delete;
@@ -204,8 +203,7 @@ public:
   void setAuthorizationCallbacks(Authorizer* authorizer);
 
 private:
-  Slave() : files(slave::READONLY_HTTP_AUTHENTICATION_REALM),
-            authorizationCallbacksSet(false) {}
+  Slave() : files(slave::READONLY_HTTP_AUTHENTICATION_REALM) {};
 
   // Not copyable, not assignable.
   Slave(const Slave&) = delete;