[GitHub] [maven-resolver] cstamas commented on a diff in pull request #285: [MRESOLVER-359] Make build be explicit about build time requirements

["cstamas (via GitHub)" <gi...@apache.org>]

cstamas commented on code in PR #285:
URL: https://github.com/apache/maven-resolver/pull/285#discussion_r1180731396


##########
pom.xml:
##########
@@ -93,7 +93,8 @@
     <guavaVersion>30.1-jre</guavaVersion>
     <guavafailureaccessVersion>1.0.1</guavafailureaccessVersion>
     <slf4jVersion>1.7.36</slf4jVersion>
-    <minimalMavenBuildVersion>3.8.4</minimalMavenBuildVersion>
+    <minimalMavenBuildVersion>[3.8.4,)</minimalMavenBuildVersion>

Review Comment:
   Is not, see https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html
   
   "3.8.4" was "x >= 3.8.4 but 3.8.4 RECOMMENDED". This is not (semantically) what we _mean_.
   What we mean is "use minimally 3.8.4 or ANY NEWER".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org