You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/21 03:52:52 UTC

[GitHub] [incubator-mxnet] stu1130 opened a new pull request #18978: Add thrust bug for windows build from source doc

stu1130 opened a new pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978


   ## Description ##
   Add thrust bug for windows build from source doc
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] stu1130 commented on pull request #18978: Add doc for building from source on windows CUDA 10.x due to a NVCC bug

Posted by GitBox <gi...@apache.org>.
stu1130 commented on pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978#issuecomment-678034132


   @leezu windos and macos have a symlink to linux. So it will show linux for file change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] stu1130 edited a comment on pull request #18978: Add doc for building from source on windows CUDA 10.x due to a NVCC bug

Posted by GitBox <gi...@apache.org>.
stu1130 edited a comment on pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978#issuecomment-678034132


   @leezu windows and macos have a symbolic link to linux. So it will show linux for file change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] stu1130 edited a comment on pull request #18978: Add doc for building from source on windows CUDA 10.x due to a NVCC bug

Posted by GitBox <gi...@apache.org>.
stu1130 edited a comment on pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978#issuecomment-678034132


   @leezu windows and macos have a symlink to linux. So it will show linux for file change


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18978: Add thrust bug for windows build from source doc

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978#issuecomment-678023048


   Hey @stu1130 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [clang, centos-gpu, unix-gpu, sanity, edge, unix-cpu, miscellaneous, website, windows-gpu, windows-cpu, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] leezu commented on pull request #18978: Add doc for building from source on windows CUDA 10.x due to a NVCC bug

Posted by GitBox <gi...@apache.org>.
leezu commented on pull request #18978:
URL: https://github.com/apache/incubator-mxnet/pull/18978#issuecomment-678889820


   @stu1130 you can replace the symbolic link by a new file if the pages are no longer identical. However, the file you edited is related to the pip wheel. Would it be more appropriate to document Windows build problems in the Windows section of the build from source page?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org