Re: svn commit: r160209 - httpd/httpd/trunk/server/mpm/winnt/child.c

["William A. Rowe, Jr." <wr...@rowe-clan.net>]

How is this worthless?  IIUC, the unix mpm's announce the
creation of each worker.  This should remain consistant,
however if I'm mistaken, ignore me.

Bill

At 02:01 PM 4/5/2005, stoddard@apache.org wrote:
>Author: stoddard
>Date: Tue Apr  5 12:01:09 2005
>New Revision: 160209
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=160209
>Log:
>Win32: Eliminate useless debug error message
>
>Modified:
>    httpd/httpd/trunk/server/mpm/winnt/child.c
>
>Modified: httpd/httpd/trunk/server/mpm/winnt/child.c
>URL: http://svn.apache.org/viewcvs/httpd/httpd/trunk/server/mpm/winnt/child.c?view=diff&r1=160208&r2=160209
>==============================================================================
>--- httpd/httpd/trunk/server/mpm/winnt/child.c (original)
>+++ httpd/httpd/trunk/server/mpm/winnt/child.c Tue Apr  5 12:01:09 2005
>@@ -739,8 +739,6 @@
>     int thread_num = (int)thread_num_val;
>     ap_sb_handle_t *sbh;
> 
>-    ap_log_error(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ap_server_conf,
>-                 "Child %d: Worker thread %d starting.", my_pid, thread_num);
>     while (1) {
>         conn_rec *c;
>         apr_int32_t disconnected;
>@@ -801,8 +799,6 @@
>     ap_update_child_status_from_indexes(0, thread_num, SERVER_DEAD, 
>                                         (request_rec *) NULL);
> 
>-    ap_log_error(APLOG_MARK, APLOG_DEBUG, APR_SUCCESS, ap_server_conf,
>-                 "Child %d: Worker thread %d exiting.", my_pid, thread_num);
>     return 0;
> }
> 

Re: svn commit: r160209 - httpd/httpd/trunk/server/mpm/winnt/child.c

[Bill Stoddard <bi...@wstoddard.com>]

Paul Querna wrote:
> William A. Rowe, Jr. wrote:
> 
>> How is this worthless?  IIUC, the unix mpm's announce the
>> creation of each worker.
> 
> 
> Worker, Prefork and Event do not.

Correct. Only Windows logs a debug message for each and every thread created. I added these two debug messages 
to winnt_mpm a couple of years back to help track down what appeared to be a shutdown bug. Problem actually 
was that thread creation at startup was failing due to the huge 1MB default stack size on windows; we now log 
thread creation failure and do our active thread accounting properly; these two debug messages unnecessarily 
clutter up the error log and we can live w/o them imho.

Bill

Re: svn commit: r160209 - httpd/httpd/trunk/server/mpm/winnt/child.c

[Paul Querna <ch...@force-elite.com>]

William A. Rowe, Jr. wrote:
> How is this worthless?  IIUC, the unix mpm's announce the
> creation of each worker.

Worker, Prefork and Event do not.