You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 02:20:16 UTC

[GitHub] [helix] kaisun2000 opened a new pull request #1586: fix TestWagedRebalance.testRebalanceTool() unstableness

kaisun2000 opened a new pull request #1586:
URL: https://github.com/apache/helix/pull/1586


   
   
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR description:
   
   resolve #1585 
   
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   The root cause is that the tool use sync mode baseline while the
   controller use async mode baseline which is not necessarily
   deterministic. Fix by make sure pipeline use sync mode and tearing
   down this config after the test.
   
   ### Tests
   
   - [ ] The following tests are written for this issue:
   
   (List the names of added unit/integration tests)
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Before CI test pass, please copy & paste the result of "mvn test")
   
   ### Documentation (Optional)
   
   - In case of new functionality, my PR adds documentation in the following wiki page:
   
   (Link the GitHub wiki you added)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on pull request #1586: fix TestWagedRebalance.testRebalanceTool() unstableness

Posted by GitBox <gi...@apache.org>.
pkuwm commented on pull request #1586:
URL: https://github.com/apache/helix/pull/1586#issuecomment-761518154


   @kaisun2000 Is this PR ready to merge?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] kaisun2000 commented on pull request #1586: fix TestWagedRebalance.testRebalanceTool() unstableness

Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on pull request #1586:
URL: https://github.com/apache/helix/pull/1586#issuecomment-772754836


   @pkuwm, this one is good to get it. Please help to merge:
   
   > fix TestWagedRebalance.testRebalanceTool() unstableness .
   The root cause is that the tool use sync mode baseline while the
   controller use async mode baseline which is not necessarily
   deterministic. Fix by make sure pipeline use sync mode and tearing
   down this config after the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm merged pull request #1586: fix TestWagedRebalance.testRebalanceTool() unstableness

Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1586:
URL: https://github.com/apache/helix/pull/1586


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org