You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Srinivas Brahmaroutu <sr...@us.ibm.com> on 2017/01/18 20:44:34 UTC
Review Request 55686: Added cpack to create source package. Currently
the
cpack source package is create in TGZ format. The sources packages are
comparable to the make dist output. There may be a need to add support to
add additional source files to the archive at some point.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Bugs: MESOS-5433
https://issues.apache.org/jira/browse/MESOS-5433
Repository: mesos
Description
-------
Added cpack to create source package. Currently the cpack source package is create in TGZ format. The sources packages are comparable to the make dist output. There may be a need to add support to add additional source files to the archive at some point.
Diffs
-----
CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f
Diff: https://reviews.apache.org/r/55686/diff/
Testing
-------
make dist
Thanks,
Srinivas Brahmaroutu
Re: Review Request 55686: Added custom target for 'make distcheck'.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/#review162238
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55657, 55686]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 18, 2017, 10:25 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55686/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 10:25 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5433
> https://issues.apache.org/jira/browse/MESOS-5433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added custom target for 'make distcheck'.
>
>
> Diffs
> -----
>
> CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f
>
> Diff: https://reviews.apache.org/r/55686/diff/
>
>
> Testing
> -------
>
> make dist
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
Re: Review Request 55686: Added custom target for 'make distcheck'.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/#review167150
-----------------------------------------------------------
I'm going to discard this, mostly because there is no canonical way for `${CMAKE_MAKE_PROGRAM}` to inherit the options of the caller. i.e. `make -j8 ...` This is further complicated by the number of `CMAKE_GENERATOR`s that exist (Ninja, MSVC, etc).
Basically, we would currently be better off running `distcheck` manually, because the caller can specify parallelism or other options as needed.
- Joseph Wu
On Jan. 18, 2017, 2:25 p.m., Srinivas Brahmaroutu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55686/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 2:25 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Bugs: MESOS-5433
> https://issues.apache.org/jira/browse/MESOS-5433
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added custom target for 'make distcheck'.
>
>
> Diffs
> -----
>
> CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f
>
> Diff: https://reviews.apache.org/r/55686/diff/
>
>
> Testing
> -------
>
> make dist
>
>
> Thanks,
>
> Srinivas Brahmaroutu
>
>
Re: Review Request 55686: Added custom target for 'make distcheck'.
Posted by Srinivas Brahmaroutu <sr...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 10:25 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
make distcheck will untar the TGZ file under build directory
The custom target will then create a build directory into that
directory and runs a 'make check' to validate the source archive.
Bugs: MESOS-5433
https://issues.apache.org/jira/browse/MESOS-5433
Repository: mesos
Description
-------
Added custom target for 'make distcheck'.
Diffs (updated)
-----
CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f
Diff: https://reviews.apache.org/r/55686/diff/
Testing
-------
make dist
Thanks,
Srinivas Brahmaroutu
Re: Review Request 55686: Added custom target for 'make distcheck'.
Posted by Srinivas Brahmaroutu <sr...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55686/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 10:22 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Currently the cpack source package is create in TGZ format.
The sources packages are comparable to the make dist output.
There may be a need to add support to add additional source
files to the archive at some point.
Summary (updated)
-----------------
Added custom target for 'make distcheck'.
Bugs: MESOS-5433
https://issues.apache.org/jira/browse/MESOS-5433
Repository: mesos
Description (updated)
-------
Added custom target for 'make distcheck'.
Diffs (updated)
-----
CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f
Diff: https://reviews.apache.org/r/55686/diff/
Testing
-------
make dist
Thanks,
Srinivas Brahmaroutu