You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/07/30 03:50:49 UTC
[PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Yicong-Huang opened a new pull request, #7112:
URL: https://github.com/apache/texera/pull/7112
### What changes were proposed in this PR?
Backport of #6402 to `release/v1.2`, cherry-picked from bf25dd2d47ab7ea7bcbd4bb7b7e9e1f41ec195eb.
Follows the Direct Backport Push convention; opened as a PR (rather than a direct push) as part of a backport-coverage audit for fixes merged to `main` since early June that were never labeled for backport.
### Any related issues, documentation, discussions?
Backport of #6402. Originally linked #6559.
### How was this PR tested?
Release-branch CI runs once the conflicts are resolved and this PR is marked ready for review. The cherry-pick **conflicted** and was committed with conflict markers.
### Was this PR authored or co-authored using generative AI tooling?
Yes — backport prepared with Claude Code (mechanical cherry-pick; conflicts left as markers for the original author to resolve; the change itself is #6402 by its original author).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #7112:
URL: https://github.com/apache/texera/pull/7112#issuecomment-5126542997
Closing after a second look: despite the `fix(` prefix, #6402 is substantively a feature, not a bug fix, and shouldn't ride onto a release branch. It adds a new required `email` field to the Sign Up flow (a UI field that didn't exist), changes the `UserRegistrationRequest` API contract from `(username, password)` to `(username, email, password)` — a breaking change for v1.2 clients — and adds new email format/uniqueness validation. v1.2's current registration (email defaults to username) works as-is; this would change release-line behavior rather than fix a regression/crash/security issue. If capturing a real email at registration is wanted on v1.2, it should go in as a deliberate, reviewed change, not an automatic backport.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #7112:
URL: https://github.com/apache/texera/pull/7112#issuecomment-5126202037
The cherry-pick **conflicted** and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review.
**Conflicting files:**
- `frontend/src/app/common/service/user/auth.service.spec.ts`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7112:
URL: https://github.com/apache/texera/pull/7112#issuecomment-5126203351
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@aglinxinyuan`, `@jaeyun0503`, `@Ma77Ball`
You can notify them by mentioning `@aglinxinyuan`, `@jaeyun0503`, `@Ma77Ball` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #7112:
URL: https://github.com/apache/texera/pull/7112#issuecomment-5126472098
Resolved: the only conflict was a modify/delete on `frontend/src/app/common/service/user/auth.service.spec.ts`, which is main-only (added later by #6470) — removed it. All source hunks (registration email on `AuthResource`/`UserRegistrationRequest`, `auth.service.ts`, local-login UI) and the meaningful feature tests (`local-login.component.spec.ts`, `user.service.spec.ts`) applied cleanly. Rebuilt as a single clean commit; marking ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7112:
URL: https://github.com/apache/texera/pull/7112#issuecomment-5126278030
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/7112?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `59.09091%` with `9 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.18%. Comparing base ([`29c3469`](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aecee94`](https://app.codecov.io/gh/apache/texera/commit/aecee945f34ff204463ed3cc8ec7eb3a64439c2c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/7112?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ontend/src/app/common/service/user/user.service.ts](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fcommon%2Fservice%2Fuser%2Fuser.service.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9jb21tb24vc2VydmljZS91c2VyL3VzZXIuc2VydmljZS50cw==) | 28.57% | [2 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...onent/about/local-login/local-login.component.html](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fhub%2Fcomponent%2Fabout%2Flocal-login%2Flocal-login.component.html&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9odWIvY29tcG9uZW50L2Fib3V0L2xvY2FsLWxvZ2luL2xvY2FsLWxvZ2luLmNvbXBvbmVudC5odG1s) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...mponent/about/local-login/local-login.component.ts](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&filepath=frontend%2Fsrc%2Fapp%2Fhub%2Fcomponent%2Fabout%2Flocal-login%2Flocal-login.component.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZnJvbnRlbmQvc3JjL2FwcC9odWIvY29tcG9uZW50L2Fib3V0L2xvY2FsLWxvZ2luL2xvY2FsLWxvZ2luLmNvbXBvbmVudC50cw==) | 77.77% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/texera/pull/7112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release/v1.2 #7112 +/- ##
==================================================
+ Coverage 52.49% 54.18% +1.68%
+ Complexity 2498 1449 -1049
==================================================
Files 1077 809 -268
Lines 42296 34188 -8108
Branches 4551 3456 -1095
==================================================
- Hits 22203 18524 -3679
+ Misses 18782 14752 -4030
+ Partials 1311 912 -399
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.35% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.73% <ø> (+7.18%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `60.53% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.51% <59.09%> (+0.18%)` | :arrow_up: | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.97% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.80% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/7112/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [29c3469](https://app.codecov.io/gh/apache/texera/commit/29c34699e3949e1ca15c3020870a5eb2a6b1f008?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/7112?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(user, v1.2): Add user email as part of registration in authentication [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed pull request #7112: fix(user, v1.2): Add user email as part of registration in authentication
URL: https://github.com/apache/texera/pull/7112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org