You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/20 02:53:45 UTC
[GitHub] [spark] tobiasedwards opened a new pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
tobiasedwards opened a new pull request #33428:
URL: https://github.com/apache/spark/pull/33428
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This change changes the type annotations for `pyspark.sql.types.Row`'s `__new__` and `__init__` methods when invoked without keyword arguments (_i.e._, `*args` rather than `**kwargs`) from `str` to `Any`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When creating a [Row](https://hyukjin-spark.readthedocs.io/en/latest/reference/api/pyspark.sql.types.Row.html) with unnamed fields which are not of type `str` (_e.g._, `row1 = Row("Alice", 11)` appears in the `Row` documentation) type checkers produce an error.
The implementation doesn't assume the arguments are of type `str`, and in fact the documentation includes an example where non-`str` types are provided in this way (see [the final example here](https://hyukjin-spark.readthedocs.io/en/latest/reference/api/pyspark.sql.types.Row.html)).
An example of the type error produced by [pyright](https://github.com/microsoft/pyright) is
```
error: No overloads for "__init__" match the provided arguments
Argument types: (Literal['Alice'], Literal[11]) (reportGeneralTypeIssues)
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
It changes the python type annotation for `Row`, which is user facing. The change makes the type annotation more general, and should not be a breaking change in any sense.
The previous type annotation behaves like so:
```python
# Will not produce type errors:
Row("Alice", "Bob")
# Will produce type errors:
Row("Alice", 11)
```
After this change, both lines will be accepted by a type checker.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
- [x] MyPy tests of PySpark source code
```
mypy --no-incremental --config python/mypy.ini python/pyspark
```
For me, this currently fails on `master` with the following errors:
```
python/pyspark/mllib/tree.pyi:29: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/tree.pyi:38: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:34: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:42: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:48: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:54: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:76: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:124: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/feature.pyi:165: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/clustering.pyi:45: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/clustering.pyi:72: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/classification.pyi:39: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
python/pyspark/mllib/classification.pyi:52: error: Overloaded function signatures 1 and 2 overlap with incompatible return types
Found 13 errors in 4 files (checked 314 source files)
```
Re-running after my change doesn't introduce any new errors. MyPy version 0.910 was used.
Tagging @HyukjinKwon and @zero323 as you both seem to have worked on type annotations recently. Thanks in advance for your help 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883179409
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45815/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33428:
URL: https://github.com/apache/spark/pull/33428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883015705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883039820
ah actually this is the limitation .. I can;t retrigger the test because it belongs to your repo :-) .. can you rebase and push it again? e.g.) `git checkout python-sql-row-type-annotation && git fetch upstream && git rebase upstream master && git push origin python-sql-row-type-annotation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883215493
(the other test failures in GA look unrelated. should be fine to go ahead and merge)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883289790
I am sitting on the fence here. While
```python
Row("Alice", 11)
```
is a technically valid initialization of a `Row`, I always considered it actual usage a code-smell. Hence the choice of annotations, where `*args` form is intended to be used with combination with `__call__`. Using it to initialize unnamed `Rows` is not only rather inefficient, but also leaves us with this awkward object, which is intended as factory of named `Rows`, but never used as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883137741
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883014506
yeah, looks like we should fix. Would you mind filing a JIRA and link it to the PR title please? (see also https://spark.apache.org/contributing.html). Also please enable GitHub Actions in your forked reopository - Apache Spark leverages the resources allocated to your forked repository (see https://github.com/apache/spark/pull/33428/checks?check_run_id=3110204626)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-960309912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33428:
URL: https://github.com/apache/spark/pull/33428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-885580383
If it functions as a warning for unintended usage, that seems OK. But it would need to be clearly documented why this isn't used this way. Maybe we need to fix the example that shows the unintended usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883179409
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45815/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
**[Test build #141301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141301/testReport)** for PR 33428 at commit [`f4330a5`](https://github.com/apache/spark/commit/f4330a5abbd87c19191764b59bb5d55bf6472432).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883039820
ah actually this is the limitation .. I can;t retrigger the test because it belongs to your repo :-) .. can you rebase and push it again? e.g.) `git checkout python-sql-row-type-annotation && git fetch upstream && git rebase upstream master && git push origin python-sql-row-type-annotation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883011701
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883053001
There we go, that should be better.
When I botched the rebase the bot added some incorrect labels though, are you able to remove them, @HyukjinKwon?
Thanks again for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883060656
Jenkins, ok to test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883049975
Whoops I think I've messed up my rebase, give me a minute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883118578
**[Test build #141301 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141301/testReport)** for PR 33428 at commit [`f4330a5`](https://github.com/apache/spark/commit/f4330a5abbd87c19191764b59bb5d55bf6472432).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883015705
Will do, thanks for that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883014506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883801095
Thanks @zero323 for chiming in on this, that's really interesting insight. I'm new to working with PySpark and hadn't realised it was a discouraged use case.
Given it is a valid initialization, and is included in the docs, my position is that we should fix the type annotation and then add to the documentation to explain this/deprecate this type of initialization later.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-884843089
I'd like to wait and see if other folks are interested in giving some feedback.
On top of the concerns raised above, there is also a matter of ambiguity introduced by application of `Any`. In particular, we want users to avoid creating `Rows` with fields that cannot be referenced:
```python
>>> a42 = Row("a", 42)
>>> a42instance = a42("foo", "bar")
>>> a42instance[42]
Traceback (most recent call last):
...
IndexError: tuple index out of range
>>> a42instance["42"]
Traceback (most recent call last):
...
ValueError: 42
```
Personally, I believe that it's better to have useful annotations which cover majority of known use cases, rather than too broad annotations that cover edge scenarios, but make annotations useless for majority of users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-886432379
> Yeah, if it gets too long to write up in the type annotation for all valid cases, we could just use `Any` for now, and document the expected usage for now.
Just a clarification ‒ as is, I don't think we can have meaningful annotation if we want to annotate this specific usage. Once we have `*args: Any` it will make any other signature ambiguous. In other words there is no way to tell what is the intention behind code like this:
```
Row("foo", "bar")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-885585554
Yeah, if it gets too long to write up in the type annotation for all valid cases, we could just use `Any` for now, and document the expected usage for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883137741
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141301/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33428:
URL: https://github.com/apache/spark/pull/33428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zero323 commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
zero323 commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883289790
I am sitting on the fence here. While
```python
Row("Alice", 11)
```
is a technically valid initialization of a `Row`, I always considered it actual usage a code-smell. Hence the choice of annotations, where `*args` form is intended to be used with combination with `__call__`. Using it to initialize unnamed `Rows` is not only rather inefficient, but also leaves us with this awkward object, which is intended as factory of named `Rows`, but never used as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883023465
Hey @HyukjinKwon, I've added a Jira ticket here: [SPARK-36220](https://issues.apache.org/jira/browse/SPARK-36220) and enabled GitHub Actions on my forked repo. Is there anything I need to do to kick off the "Build and test" action again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883039820
ah actually this is the limitation .. I can;t retrigger the test because it belongs to your repo :-) .. can you rebase and push it again? e.g.) `git checkout python-sql-row-type-annotation && git fetch upstream && git rebase upstream master && git push origin python-sql-row-type-annotation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
**[Test build #141301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141301/testReport)** for PR 33428 at commit [`f4330a5`](https://github.com/apache/spark/commit/f4330a5abbd87c19191764b59bb5d55bf6472432).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883154137
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45815/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
**[Test build #141301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141301/testReport)** for PR 33428 at commit [`f4330a5`](https://github.com/apache/spark/commit/f4330a5abbd87c19191764b59bb5d55bf6472432).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-960309912
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883701923
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883014506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tobiasedwards commented on pull request #33428: [PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
tobiasedwards commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883015705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883039820
ah actually this is the limitation .. I can;t retrigger the test because it belongs to your repo :-) .. can you rebase and push it again? e.g.) `git checkout python-sql-row-type-annotation git fetch upstream && git rebase upstream master && git push origin python-sql-row-type-annotation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883215206
Looks correct to me but I would defer to @zero323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
**[Test build #141301 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141301/testReport)** for PR 33428 at commit [`f4330a5`](https://github.com/apache/spark/commit/f4330a5abbd87c19191764b59bb5d55bf6472432).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33428: [SPARK-36220][PYTHON] Fix pyspark.sql.types.Row type annotation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33428:
URL: https://github.com/apache/spark/pull/33428#issuecomment-883088661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org