[GitHub] [incubator-tvm] tqchen commented on pull request #6138: Add `init` member to ReduceNode

[GitBox <gi...@apache.org>]

tqchen commented on pull request #6138:
URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-670992782


   Thanks @quic-sanirudh for proposing the new change. My only conern wrt to the custom initialization value is that it might break the follow up primitives, e.g. rfactor and cross thread allreduce will require the init value to be the identity element. As a result, we might want to pause a bit.
   
   The initial value can still be added by introducing an additional stage(with a small overhead).
   
   As part of this cycle, there is plan to introduce scheduling for TIR, which might bring the possibility to include such custom initialization stage, which we can then support this feature


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org