You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2009/12/20 17:40:18 UTC
[jira] Issue Comment Edited: (SOLR-1674) improve analysis tests,
cut over to new API
[ https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793001#action_12793001 ]
Robert Muir edited comment on SOLR-1674 at 12/20/09 4:39 PM:
-------------------------------------------------------------
Hello, I see Uwe has commented on SOLR-1657 that he would help convert tokenstreams to the new api, but he needs this patch (the tests) applied first.
Is it possible for someone to take a look at this patch to get things moving along? its only tests, no source code changes.
was (Author: rcmuir):
Hello, I see Uwe has commented on SOLR-1657 that he would help convert tokenstreams to Solr's api, but he needs this patch (the tests) applied first.
Is it possible for someone to take a look at this patch to get things moving along? its only tests, no source code changes.
> improve analysis tests, cut over to new API
> -------------------------------------------
>
> Key: SOLR-1674
> URL: https://issues.apache.org/jira/browse/SOLR-1674
> Project: Solr
> Issue Type: Test
> Components: Schema and Analysis
> Reporter: Robert Muir
> Attachments: SOLR-1674.patch, SOLR-1674.patch
>
>
> This patch
> * converts all analysis tests to use the new tokenstream api
> * converts most tests to use the more stringent assertion mechanisms from lucene
> * adds new tests to improve coverage
> Most bugs found by more stringent testing have been fixed, with the exception of SynonymFilter.
> The problems with this filter are more serious, the previous tests were essentially a no-op.
> The new tests for SynonymFilter test the current behavior, but have FIXMEs with what I think the old test wanted to expect in the comments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.