You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "boglesby (GitHub)" <gi...@apache.org> on 2019/01/16 20:07:27 UTC
[GitHub] [geode] boglesby opened pull request #3084: GEODE-6267:
Logged out subject
The changes to CacheClientProxy closeTransientFields and closeOtherTransientFields are to address the bug I found while debugging this leak.
The main changes to address the leak are to invoke removeSubject in ClientUserAuths. cleanup and logout in CacheClientProxy.closeOtherTransientFields.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Yes, the transient fields should be closed (or cleaned up) when the CacheClientProxy closes.
They are mostly related to the socket. Transient fields are:
- _socket
- _commBuffer - ByteBuffer on the socket
- releaseResourcesForAddress - removes the asyncCloseExecutors for the proxy's _remoteHostAddress
- clearClientInterestList and closeNonDurableCqs - remove interests and CQs
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Thanks for the suggestion. Fixed.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
probably mark this as @VisibleForTesting
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Thanks for the suggestion. Fixed.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
probably mark this as @VisibleForTesting
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Thanks for the suggestion. Fixed.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby closed pull request #3084: GEODE-6267:
Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
[ pull request closed by boglesby ]
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
you can also replace these lines with:
```
server = cluster.startServerVM(1, s->s.withCredential("cluster", "cluster").withConnectionToLocator(locator.getPort()).withRegion(RegionShortcut.PARTITION, "region"));
```
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Thanks for the suggestion. Fixed.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] boglesby commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "boglesby (GitHub)" <gi...@apache.org>.
Thanks for the suggestion. Fixed.
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
I wonder what block 965-967 would do. Can we always close all these transient fields no matter what?
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #3084:
GEODE-6267: Logged out subject
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
you can also do: `locator = cluster.startLocatorVM(0, l->l.withSecurityManager(SimpleSecurityManager.class));`
[ Full content available at: https://github.com/apache/geode/pull/3084 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org