[jira] [Updated] (SQOOP-2436) PreCommit script crashes when testing a patch that was already committed

["Jarek Jarcec Cecho (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SQOOP-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Jarcec Cecho updated SQOOP-2436:
--------------------------------------
    Attachment: SQOOP-2436.patch

Attaching fix and skipping review board because it's one line change.

The problem is that I've miss-spelled a variable name during the refactoring. Because python is not verifying variable names until run time and because I did not verify this particular branch, I've missed it. My apologies.

> PreCommit script crashes when testing a patch that was already committed
> ------------------------------------------------------------------------
>
>                 Key: SQOOP-2436
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2436
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Gwen Shapira
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2436.patch
>
>
> Test: Apply a patch that was committed.
> Expected: Nice message saying "already committed" or "can't apply"
> Actual:
> {code}
> gshapira-MBP:sqoop2 gshapira$ dev-support/test-patch.py --defect SQOOP-2428 --output patch-process --run-integration-tests
> Defect: SQOOP-2428
> INFO: URL = https://issues.apache.org/jira/rest/api/2/issue/SQOOP-2428, Username = flumeqa, data = None, headers = {}
> INFO: URL = https://issues.apache.org/jira/browse/SQOOP-2428, Username = flumeqa, data = None, headers = {}
> INFO: URL = https://issues.apache.org/jira/secure/attachment/12747186/SQOOP-2428.patch, Username = flumeqa, data = None, headers = {}
> INFO: Executing mvn clean 1>patch-process/clean.txt 2>&1
> INFO: Executing git checkout sqoop2
> Already on 'sqoop2'
> Your branch is up-to-date with 'origin/sqoop2'.
> INFO: Executing git clean -d -f
> INFO: Executing git reset --hard HEAD
> HEAD is now at 7e63724 SQOOP-2428: Sqoop2: Precommit: Print actions in order they've been executed
> INFO: Executing git fetch origin
> INFO: Executing git merge --ff-only origin/sqoop2
> Already up-to-date.
> INFO: Executing git apply -p1 < patch-process/SQOOP-2428.patch 1>patch-process/apply.txt 2>&1
> Traceback (most recent call last):
>   File "dev-support/test-patch.py", line 486, in <module>
>     git_apply(result, patch_cmd, patch_file, strip, output_dir)
>   File "dev-support/test-patch.py", line 222, in git_apply
>     result.fatal("Failed to apply patch (exit code %d):\n{code}%s{code}\n" % (rc, output))
>   File "dev-support/test-patch.py", line 355, in fatal
>     self._items.append(ResultItem(ResultsIem.FATAL, msg, bullets))
> NameError: global name 'ResultsIem' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)